Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated code to allow sidenav expand on click #2256

Merged
merged 35 commits into from
Jan 14, 2025
Merged

Updated code to allow sidenav expand on click #2256

merged 35 commits into from
Jan 14, 2025

Conversation

alexjanousekGSA
Copy link
Contributor

@alexjanousekGSA alexjanousekGSA commented Jan 9, 2025 •
edited
Loading

Navbar improvements

  • Update nav for production release #2233
  • When clicking on About Notify, a subnav will now open that maintains style consistency with its parent links.
  • Header navbar is updated with active state when sublinks are clicked.
  • This overrides uswds default components

Relevant Screenshots
image

image
image
image
image

@alexjanousekGSA
Copy link
Contributor Author

image The changes made here to allow a larger width for the sidenav affected all sidenavs globally and pushed content to the side. BackstopJS highlighted this well and we are discussing now if we will keep the width or make it a case by case basis. In this specific screenshot you can see some content needs a slight update to fit in the smaller space.

@alexjanousekGSA alexjanousekGSA self-assigned this Jan 12, 2025
@alexjanousekGSA alexjanousekGSA linked an issue Jan 12, 2025 that may be closed by this pull request
Update nav for production release #2233
Closed
4 tasks
@alexjanousekGSA
Copy link
Contributor Author

I believe all comments and updates and tests are fixed and this PR is ready for review and approvals!!

heyitsmebev
heyitsmebev requested changes Jan 14, 2025
View reviewed changes
@heyitsmebev heyitsmebev self-requested a review January 14, 2025 18:55
@heyitsmebev
Copy link
Contributor

Thank you!!!! Lightning speed! It looks great to me ✅

heyitsmebev
heyitsmebev approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@heyitsmebev heyitsmebev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM!

jonathanbobel
jonathanbobel approved these changes Jan 14, 2025
View reviewed changes
Copy link
Contributor

@jonathanbobel jonathanbobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathanbobel jonathanbobel merged commit b926b2d into main Jan 14, 2025
11 checks passed
@jonathanbobel jonathanbobel deleted the feature/sidenav-expand-sublinks branch January 14, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanbobel jonathanbobel jonathanbobel approved these changes

@heyitsmebev heyitsmebev heyitsmebev approved these changes

@dmvancura dmvancura Awaiting requested review from dmvancura

@ccostino ccostino Awaiting requested review from ccostino

Assignees

@alexjanousekGSA alexjanousekGSA

Labels
None yet
Projects
Notify.gov product board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update nav for production release
3 participants
@alexjanousekGSA @heyitsmebev @jonathanbobel