Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

retry in cypress #1535

Merged
merged 1 commit into from
Jan 16, 2025
Merged

retry in cypress #1535

merged 1 commit into from
Jan 16, 2025

Conversation

FuhuXia
Copy link
Member

@FuhuXia FuhuXia commented Jan 16, 2025

Retry when cypress failed. We have seen too many cases where flaky cypress passes failed tests after manual retry. This is automated retry offered by cypress.

@FuhuXia FuhuXia requested a review from a team January 16, 2025 20:09
btylerburton
btylerburton approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@btylerburton btylerburton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At least the tests passed... 😂

@btylerburton btylerburton merged commit e904d63 into main Jan 16, 2025
9 checks passed
@btylerburton btylerburton deleted the cypress-retry branch January 16, 2025 20:24
@FuhuXia
Copy link
Member Author

FuhuXia commented Jan 23, 2025

At least the tests passed... 😂

Proof shows it is retrying.

test-1  |   Prepare
test-1  |     ✓ Test Org is present (12234ms)
test-1  |     (Attempt 1 of 3) Test Dataset is present
test-1  |     (Attempt 2 of 3) Test Dataset is present
test-1  |     1) Test Dataset is present
test-1  |

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btylerburton btylerburton btylerburton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FuhuXia @btylerburton