Update filenames to reflect new test ID format #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jan 26, 2021
There was a problem hiding this comment.
This is in line with my understanding that the revised test case id is generated based on the following logic:
- "06.1" points to baseline test "6.1 Test Procedure for Meaningful Images"
- "-" hyphen separator
- "1" points to the appropriate baseline test step
- "-" hyphen separator
- "fail" expected outcome of this test case
- "-" hyphen separator
- "1" points to an incrementor that can be any value that results in a unique composite test case id
|
Thanks for the review, @akingkci! These were updates only to the test files filenames. Similar updates are needed for the test case "TC" filenames and for the link in the TC to the test files. Added issue #57 for this. |
|
Got it 😊
From: Kathy Eng <[email protected]>
Sent: Tuesday, January 26, 2021 6:03 PM
To: Section508Coordinators/baselinealignment <[email protected]>
Cc: Alan King <[email protected]>; Mention <[email protected]>
Subject: Re: [Section508Coordinators/baselinealignment] Update filenames to reflect new test ID format (#56)
Thanks for the review, @akingkci<https://github.com/akingkci>!
These were updates only to the test files filenames. Similar updates are needed for the test case "TC" filenames and for the link in the TC to the test files. I'll add a separate issue for that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://github.com/Section508Coordinators/baselinealignment/pull/56#issuecomment-767884993>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMXWVN7RF3T5W4FO7II74WLS35C4DANCNFSM4WTTBA4A>.
|
drewnielson
approved these changes
Jan 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated test ID Format: [Baseline Test ID#]-[test step #]-[pass/fail/dna]-[reference #]