fix specs

spec/factories/submission.rb

@@ -4,6 +4,7 @@
     association :challenge
     association :phase
     association :submitter, factory: :user
+    association :manager, factory: :user
     # don't think we need this anymore?
     # association :manager, factory: :user
 

spec/requests/phases_spec.rb

@@ -46,8 +46,7 @@
       end
 
       it "renders a list of challenges" do
-        agency = Agency.create!(name: "Gandalf and Sons", acronym: "GAD")
-        challenge = Challenge.create!(user: challenge_user, agency:, title: "Turning monster energy into pepto bismol")
+        challenge = create(:challenge, user: challenge_user, title: "Turning monster energy into pepto bismol")
         phase = create_phase(challenge_id: challenge.id)
         ChallengeManager.create(user: challenge_user, challenge:)
         create_evaluation_form(title: "Frodo", challenge_id: challenge.id, phase_id: phase.id)

spec/system/phases_spec.rb

@@ -3,15 +3,13 @@
 require 'rails_helper'
 
 describe "A11y", :js do
-  let(:user) { nil }
-
-  before do
-    system_login_user(user) if user
-  end
-
   describe "Logged-in as a Challenge Manager" do
     let(:user) { create_user(role: "challenge_manager") }
 
+    before do
+      system_login_user(user)
+    end
+
     it "manage phases index page is accessible with no challenges" do
       visit phases_path
       expect(user.role).to eq("challenge_manager")