Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev test db #1525

Merged
merged 4 commits into from
Jan 24, 2025
Merged

Dev test db #1525

merged 4 commits into from
Jan 24, 2025

Conversation

jdonis
Copy link
Contributor

@jdonis jdonis commented Jan 24, 2025

Description

[Provide a brief description of the changes implemented in this pull request.]

Related Issues

[Reference any related issues, if applicable.]

Changes Made

  • [List the specific changes made in bullet points.]

Screenshots (if applicable)

[Include screenshots to visually demonstrate changes, if relevant.]

Checklist

  • PR is assigned to a project: Challenge_gov Board
  • PR is assigned to a milestone: current sprint
  • GH issues are assigned to the PR (under Development section on the right hand side)
  • PR is assigned a reviewer, and requires code review and approval by a teammate
  • New functionality is tested and all tests are green
  • I have added unit tests for new functionality or updated existing tests for changes.
  • I have updated the documentation/README accordingly, if necessary.
  • If you have DB migration, it is a "safe" migration and you've confirmed it can be rolled back.
  • If applicable, Controllers modified contain appropriate authorization plugs
  • This PR has been reviewed by at least one other team member.
  • Build has been approved for deployment in CircleCI.

@jdonis jdonis requested review from jairoanaya and kkrug January 24, 2025 04:46
@kkrug kkrug merged commit c1aea52 into dev Jan 24, 2025
6 checks passed
@kkrug kkrug deleted the dev-test-db branch January 24, 2025 13:34
@kkrug
Copy link
Contributor

kkrug commented Jan 24, 2025

@jdonis I approved and merged this and restaged the application but still get the internal server error

@r-bartlett-gsa r-bartlett-gsa added this to the Sprint 01/28/25 milestone Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkrug kkrug kkrug approved these changes

@jairoanaya jairoanaya Awaiting requested review from jairoanaya

Assignees

@jdonis jdonis

Labels
None yet
Projects
None yet
Milestone
Sprint 01/28/25
Development

Successfully merging this pull request may close these issues.
3 participants
@jdonis @kkrug @r-bartlett-gsa