Fix code scanning alert no. 13: Unsafe jQuery plugin #1263
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/GSA/CFO.gov/security/code-scanning/13
To fix the problem, we need to ensure that the
markup
variable is sanitized before it is used to create a jQuery object. This can be achieved by using a method that treats the input as a CSS selector rather than HTML, thereby preventing the execution of any potentially malicious scripts. Specifically, we can usejQuery.parseHTML
to safely parse themarkup
string and ensure it does not contain any executable scripts.markup
variable is assigned (line 509).markup
to$(markup)
with a sanitized version usingjQuery.parseHTML
.Suggested fixes powered by Copilot Autofix. Review carefully before merging.