ScalarFieldBH example update #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KAClough
added
the
enhancement
|
This is mostly done now - we just need to check that it works with the ICSolver. I should probably rename the files to ScalarFieldBH to be consistent with @AreefW 's cosmo example. My python plot file for the Ham could also be improved, but let's just see if it works first... |
|
Ok, this should now be good to go I think. @SamuelBrady can you provide an independent review to check that it works ok for both the restart and running from the analytic data? If so we should merge it. @AreefW can you update your example to have the same format for restarting from GRTresna? |
SamuelBrady
force-pushed
the
feature/initial_conditions
branch
from
3f51637 to
af8a78b
Compare
SamuelBrady
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will update the ScalarField example to ScalarFieldBH, where the initial data is analytic for a constant scalar field profile around a Schwarzschild BH. This allows us to set G_Newton =1 as should be the case!
This should also allow us to read in data from the corresponding example in GRTresna (the initial conditions code that is about to be released) and plot the constraint violations to easily allow convergence testing.
I haven't fully tested yet hence the draft state.