Allow for 32 bit builds #2884
Merged
Allow for 32 bit builds #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstutt
commented
Dec 14, 2023
| @@ -86,6 +86,13 @@ inline bool operator!=(const Hash &lhs, const Hash &rhs) { | |||
| namespace std { | |||
| template <> struct hash<MetroHash::Hash> { | |||
| // Returns `hash` compacted to `size_t`. Returns zero for value-initialized hashes. | |||
| size_t operator()(const MetroHash::Hash &hash) const { return static_cast<size_t>(MetroHash::compact64(&hash)); } | |||
| size_t operator()(const MetroHash::Hash &hash) const { | |||
| if constexpr (sizeof(size_t) == 8) { | |||
There was a problem hiding this comment.
constexpr is probably not required - but it makes it more explicit what is happening.
The amdllpc unit tests fail for 32 bit builds due to the 64 bit specific code in vkgcMetroHash (assumptions are made about size_t). Use compact32 for 32 bit builds instead.
dstutt
force-pushed
the
llpc-unit-32bit
branch
from
8dd06ac to
7a48c7d
Compare
Test summary for commit 7a48c7dCTS tests (Failed: 0/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Flakebi
approved these changes
Dec 14, 2023
qiaojbao
pushed a commit
that referenced
this pull request
Jan 2, 2024
The amdllpc unit tests fail for 32 bit builds due to the 64 bit specific code in vkgcMetroHash (assumptions are made about size_t). Use compact32 for 32 bit builds instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The amdllpc unit tests fail for 32 bit builds due to the 64 bit specific code in vkgcMetroHash (assumptions are made about size_t).
Use compact32 for 32 bit builds instead.