Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a regression of removing isOffChip input #2882

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Fix a regression of removing isOffChip input #2882

merged 1 commit into from
Dec 16, 2023

Conversation

amdrexu
Copy link
Contributor

@amdrexu amdrexu commented Dec 14, 2023

This is to fix a regression of
#2861. When TES is mapped to HW VS (no NGG), this SGPR must be present.

@amdrexu amdrexu requested a review from a team as a code owner December 14, 2023 10:27
@amdrexu
Fix a regression of removing isOffChip input
0c004db 
This is to fix a regression of
GPUOpen-Drivers#2861. When TES is mapped to
HW VS (no NGG), this SGPR must be present.
@amdvlk-admin
Copy link

Test summary for commit 0c004db

CTS tests (Failed: 0/138443)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@chuang13
Copy link
Contributor

@amdrexu

@amdrexu amdrexu merged commit 796a333 into GPUOpen-Drivers:dev Dec 16, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhaehnle nhaehnle nhaehnle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@amdrexu @amdvlk-admin @chuang13 @nhaehnle