Port the upstream change to optimize adding decorations

[amdrexu]

This is to port the upstream change:
KhronosGroup/SPIRV-LLVM-Translator@d56378e. It will greatly speed up the compilation time when there are lots of decorations in SPIR-V using std::vector instead of std::multiset with custom comparator.

[amdvlk-admin]

Test summary for commit 9e475f6

CTS tests (Failed: 0/138443)

• Built with version 1.3.5.2
Ubuntu navi3x, Srdcvk
• Passed: 35211/69228 (50.9%)
• Failed: 0/69228 (0.0%)
• Not Supported: 34017/69228 (49.1%)
• Warnings: 0/69228 (0.0%)
Ubuntu navi2x, Srdcvk
• Passed: 35242/69215 (50.9%)
• Failed: 0/69215 (0.0%)
• Not Supported: 33973/69215 (49.1%)
• Warnings: 0/69215 (0.0%)

[jayfoad]

I would suggest copying the original commit message ("Use std::undordered_set instead of std::multiset ...") into your commit message, to explain what this patch does.

[dstutt]

I would suggest copying the original commit message ("Use std::undordered_set instead of std::multiset ...") into your commit message, to explain what this patch does.

Am I missing something - the Khronos patch and this one both use a vector and not an unordered_set (although the justification is the same I think?)

[jayfoad]

I would suggest copying the original commit message ("Use std::undordered_set instead of std::multiset ...") into your commit message, to explain what this patch does.

Am I missing something - the Khronos patch and this one both use a vector and not an unordered_set (although the justification is the same I think?)

That changed during the review. If you look at the description of the PR it has been updated to "Use std::vector instead of std::multiset...". But the PR includes multiple commits, and the first of these actually did use unordered_set.

[amdrexu]

I would suggest copying the original commit message ("Use std::undordered_set instead of std::multiset ...") into your commit message, to explain what this patch does.

We don't need to use unordered_set. I remove this line:
template <class T, class B> spv_ostream &operator<<(spv_ostream &O, const std::multiset<T *, B> &V)
It is for LLVM -> SPIR-V translation and we removed all such backward translation previously. I will update the commit message saying we replace multiset with a vector.

[amdvlk-admin]

Test summary for commit 063c30a

CTS tests (Failed: 0/138378)

• Built with version 1.3.5.2
Ubuntu navi3x, Srdcvk
• Passed: 35162/69163 (50.8%)
• Failed: 0/69163 (0.0%)
• Not Supported: 34001/69163 (49.2%)
• Warnings: 0/69163 (0.0%)
Ubuntu navi2x, Srdcvk
• Passed: 35242/69215 (50.9%)
• Failed: 0/69215 (0.0%)
• Not Supported: 33973/69215 (49.1%)
• Warnings: 0/69215 (0.0%)

[dstutt]

LGTM