Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PatchBufferOp: fix the check condition for PreservedAnalyses #2870

Merged
merged 1 commit into from
Dec 9, 2023
Merged

PatchBufferOp: fix the check condition for PreservedAnalyses #2870

merged 1 commit into from
Dec 9, 2023

Conversation

xuechen417
Copy link
Contributor

@xuechen417 xuechen417 commented Dec 7, 2023 •
edited by tsymalla-AMD
Loading

impl.run(function) returns true means we should preserve nothing.

@xuechen417
PatchBufferOp: fix the check condition for PerservedAnalyses
787dcf9 
`impl.run(functtion)` returns true means we should perseve nothing.
@xuechen417 xuechen417 requested a review from a team as a code owner December 7, 2023 06:28
@amdvlk-admin
Copy link

Test summary for commit 787dcf9

CTS tests (Failed: 0/138378)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35162/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34001/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35241/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33974/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@tsymalla-AMD tsymalla-AMD changed the title PatchBufferOp: fix the check condition for PerservedAnalyses PatchBufferOp: fix the check condition for PreservedAnalyses Dec 7, 2023
nhaehnle
nhaehnle approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops :) Thanks!

@amdrexu amdrexu merged commit daf27f7 into GPUOpen-Drivers:dev Dec 9, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsymalla-AMD tsymalla-AMD tsymalla-AMD approved these changes

@nhaehnle nhaehnle nhaehnle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@xuechen417 @amdvlk-admin @nhaehnle @tsymalla-AMD @amdrexu