Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in markGenericInputOutputUsage #2868

Closed
wants to merge 1 commit into from
Closed

Fix a typo in markGenericInputOutputUsage #2868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions lgc/builder/InOutBuilder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ Value *BuilderImpl::readGenericInputOutput(bool isOutput, Type *resultTy, unsign
assert(isOutput == false || m_shaderStage == ShaderStageTessControl);

// Fold constant locationOffset into location. (Currently a variable locationOffset is only supported in
// TCS, TES, and FS custom interpolation.)
// TCS, TES, mesh shader, and FS custom interpolation.)
bool isDynLocOffset = true;
if (auto constLocOffset = dyn_cast<ConstantInt>(locationOffset)) {
location += constLocOffset->getZExtValue();
Expand Down Expand Up @@ -409,7 +409,10 @@ void BuilderImpl::markGenericInputOutputUsage(bool isOutput, unsigned location,
origLocationInfo.setLocation(i);
origLocationInfo.setComponent(inOutInfo.getComponent());
auto &newLocationInfo = (*inOutLocInfoMap)[origLocationInfo];
newLocationInfo.setData(isDynLocOffset ? i : InvalidValue);
if (isDynLocOffset)
newLocationInfo.setLocation(i);
else
newLocationInfo.setData(InvalidValue);
}
}
if (perPatchInOutLocMap) {
Expand Down
Loading