Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable shaderdb tests now upstream llvm changes are propagated #2838

Merged
merged 1 commit into from
Nov 24, 2023
Merged

Re-enable shaderdb tests now upstream llvm changes are propagated #2838

merged 1 commit into from
Nov 24, 2023

Conversation

dstutt
Copy link
Member

@dstutt dstutt commented Nov 23, 2023

LLVM updates are now in the repo so we can re-enable these tests.

@dstutt dstutt requested a review from a team as a code owner November 23, 2023 09:18
@dstutt dstutt mentioned this pull request Nov 23, 2023
Merged
Flakebi
Flakebi previously approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passes

@amdvlk-admin
Copy link

Test summary for commit 7ecfb52

CTS tests (Failed: 1018/138378)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35162/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34001/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 34235/69215 (49.5%)
    • Failed: 1018/69215 (1.5%)

      Failures:

      FAILURE: dEQP-VK.api.buffer.suballocation.storage.index.indirect.create.binding
Stack trace: Flake

FAILURE: dEQP-VK.api.buffer.suballocation.transfer_src.uniform_texel.vertex.create.binding_residency
Stack trace: Flake

FAILURE: dEQP-VK.api.buffer_marker.graphics.external_host_mem.bottom_of_pipe.memory_dep.draw
Stack trace: Flake

FAILURE: dEQP-VK.api.buffer_view.access.uniform_texel_buffer.a2b10g10r10_uint_pack32
Stack trace: Flake

FAILURE: dEQP-VK.api.buffer_view.access.uniform_texel_buffer.r16g16_sfloat
Stack trace: Flake

FAILURE: dEQP-VK.api.buffer_view.access.uniform_texel_buffer.r32_sfloat
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.copy_commands2.buffer_to_depthstencil.buffer_offset_d32_sfloat_s8_uint_D_S
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.copy_commands2.depth_stencil_msaa_copy.whole.d16_unorm_s8_uint_general_optimal_D_4_bit
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.core.buffer_to_depthstencil.d32_sfloat_s8_uint_S
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.core.depth_stencil_msaa_copy.whole.d32_sfloat_optimal_general_D_2_bit
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.dedicated_allocation.blit_image.simple_tests.mirror_y_3d.b8g8r8a8_unorm_nearest
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.dedicated_allocation.blit_image.simple_tests.without_scaling_partial_3d.r32_sfloat_nearest
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.dedicated_allocation.buffer_to_buffer.partial
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.dedicated_allocation.buffer_to_depthstencil.buffer_offset_d32_sfloat_s8_uint_DS
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.dedicated_allocation.buffer_to_depthstencil.d16_unorm_s8_uint_S
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.dedicated_allocation.depth_stencil_msaa_copy.whole.d16_unorm_s8_uint_optimal_general_D_2_bit
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.dedicated_allocation.image_to_image.dimensions.src4x8192_dst4x8192.r4g4_unorm_pack8.r8_srgb.general_general
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.dedicated_allocation.image_to_image.simple_tests.partial_image
Stack trace: Flake

FAILURE: dEQP-VK.api.fill_and_update_buffer.dedicated_alloc.fill_buffer_vk_whole_size_0_extra_bytes_offset_0
Stack trace: Flake

FAILURE: dEQP-VK.api.image_clearing.core.clear_color_image.2d.linear.multiple_layers.r32g32b32a32_uint_64x11
Stack trace: Flake
...

    • Not Supported: 33962/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@qiaojbao
Copy link
Collaborator

Seems the llvm update caused many navi2x cts failures
dev @ 3ab181f6d3ad0c309c702b26143d04a2104d0778

@dstutt
Copy link
Member Author

dstutt commented Nov 23, 2023

Seems the llvm update caused many navi2x cts failures dev @ 3ab181f6d3ad0c309c702b26143d04a2104d0778

Maybe - the test agent for navi2x seemed to be in a strange state so I've tried a reboot. But I'm not very sure it'll make any difference.

@qiaojbao
Copy link
Collaborator

qiaojbao commented Nov 23, 2023 •
edited
Loading

Seems the llvm update caused many navi2x cts failures dev @ 3ab181f6d3ad0c309c702b26143d04a2104d0778

Maybe - the test agent for navi2x seemed to be in a strange state so I've tried a reboot. But I'm not very sure it'll make any difference.
The test agent will try reboot, if there are many amdgpu error info in dmesg.
I retrigger this PR, and the navi2x agent run the cts test after a reboot, many failures observed.

@amdvlk-admin
Copy link

Test summary for commit febcfb6

CTS tests (Failed: 1208/138443)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 34047/69215 (49.2%)
    • Failed: 1208/69215 (1.7%)

      Failures:

      FAILURE: dEQP-VK.api.buffer.suballocation.transfer_src.uniform_texel.vertex.create.binding_residency
Stack trace: Flake

FAILURE: dEQP-VK.api.buffer.suballocation.vertex.indirect.create.binding_residency
Stack trace: Flake

FAILURE: dEQP-VK.api.buffer_marker.graphics.external_host_mem.bottom_of_pipe.memory_dep.draw
Stack trace: Flake

FAILURE: dEQP-VK.api.buffer_view.access.uniform_texel_buffer.a2b10g10r10_uint_pack32
Stack trace: Flake

FAILURE: dEQP-VK.api.buffer_view.access.uniform_texel_buffer.r32_sfloat
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.copy_commands2.blit_image.all_formats.color.3d.a8b8g8r8_sint_pack32.a8b8g8r8_sint_pack32.optimal_optimal_nearest_stripes_x
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.copy_commands2.blit_image.all_formats.color.3d.r16g16b16a16_snorm.r16g16b16a16_snorm.optimal_general_linear_stripes_x
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.copy_commands2.depth_stencil_msaa_copy.whole.d16_unorm_s8_uint_general_general_D_2_bit
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.copy_commands2.resolve_image.diff_image_size.dst_266_256_1_4_bit
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.copy_commands2.resolve_image.with_regions.2_bit
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.core.blit_image.simple_tests.scaling_whole2_3d.r32_sfloat_nearest
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.core.buffer_to_depthstencil.d32_sfloat_s8_uint_S
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.core.depth_stencil_msaa_copy.partial.s8_uint_S_4_bit
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.core.depth_stencil_msaa_copy.whole.d32_sfloat_optimal_general_D_2_bit
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.dedicated_allocation.buffer_to_buffer.partial
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.dedicated_allocation.buffer_to_depthstencil.buffer_offset_d32_sfloat_s8_uint_DS
Stack trace: Flake

FAILURE: dEQP-VK.api.copy_and_blit.dedicated_allocation.resolve_image.with_regions.2_bit
Stack trace: Flake

FAILURE: dEQP-VK.api.fill_and_update_buffer.dedicated_alloc.fill_buffer_first_one
Stack trace: Flake

FAILURE: dEQP-VK.api.image_clearing.core.clear_color_image.2d.linear.multiple_layers.r32g32b32a32_uint_64x11
Stack trace: Flake

FAILURE: dEQP-VK.api.image_clearing.core.clear_color_image.2d.optimal.remaining_array_layers_twostep.e5b9g9r9_ufloat_pack32
Stack trace: Flake
...

    • Not Supported: 33960/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@dstutt
Copy link
Member Author

dstutt commented Nov 23, 2023

Seems the llvm update caused many navi2x cts failures dev @ 3ab181f6d3ad0c309c702b26143d04a2104d0778

Maybe - the test agent for navi2x seemed to be in a strange state so I've tried a reboot. But I'm not very sure it'll make any difference.
The test agent will try reboot, if there are many amdgpu error info in dmesg.
I retrigger this PR, and the navi2x agent run the cts test after a reboot, many failures observed.

I couldn't reproduce these failure locally building from the same sources.

@dstutt
Re-enable llpc/lgc tests now upstream llvm changes are propagated
859edf3 
LLVM updates are now in the repo so we can re-enable these tests.
@dstutt
Copy link
Member Author

dstutt commented Nov 23, 2023

retest this please

@dstutt
Copy link
Member Author

dstutt commented Nov 23, 2023

test this please

nhaehnle
nhaehnle approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (unrelated CI issues aside...)

@amdvlk-admin
Copy link

Test summary for commit 859edf3

CTS tests (Failed: 0/138443)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@dstutt dstutt merged commit b20c37c into GPUOpen-Drivers:dev Nov 24, 2023
9 checks passed
@dstutt dstutt deleted the re-enable-tests branch November 24, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhaehnle nhaehnle nhaehnle approved these changes

@Flakebi Flakebi Flakebi left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dstutt @amdvlk-admin @qiaojbao @nhaehnle @Flakebi