Support vertex offset mode with new D3D12_VERTEX_BUFFER_VIEW #2836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In vertex offset mode. we will use D3D12_VERTEX_BUFFER_VIEW to replace SRD, the address and size fields are already in the right place. We only need to get stride and fill the fourth DWORD. Then we calculate offset with stride and vertex index. For Uber fetch shader, SRD will be updated in driver.
AMD-dwang
force-pushed
the
useVertexOffsetMode
branch
from
c213d76 to
130d12a
Compare
Test summary for commit 130d12aCTS tests (Failed: 0/138378)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In vertex offset mode. we will use D3D12_VERTEX_BUFFER_VIEW to replace SRD, the address and size fields are already in the right place. We only need to get stride and fill the fourth DWORD. Then we calculate offset with stride and vertex index.
For Uber fetch shader, SRD will be updated in driver.