Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix an assertion triggered in vkgcPipelineDumper #2834

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Fix an assertion triggered in vkgcPipelineDumper #2834

merged 1 commit into from
Nov 23, 2023

Conversation

LLJJDD
Copy link
Contributor

@LLJJDD LLJJDD commented Nov 22, 2023

Although we can still get meaningful value with getUInt() on a node with Int type, we are triggering assertion.

@LLJJDD
Fix an assertion triggered in vkgcPipelineDumper
1307a86 
Although we can still get meaningful value with `getUInt()` on a node with `Int`
type, we are triggering assertion.
@LLJJDD LLJJDD requested a review from a team as a code owner November 22, 2023 07:42
@amdvlk-admin
Copy link

Test summary for commit 1307a86

CTS tests (Failed: 0/138443)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@LLJJDD LLJJDD merged commit 71d8a00 into GPUOpen-Drivers:dev Nov 23, 2023
9 checks passed
@LLJJDD LLJJDD deleted the fix-pipeline-dump-assert branch November 23, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhaehnle nhaehnle nhaehnle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LLJJDD @amdvlk-admin @nhaehnle