Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert the PR#2804 handling specials input of fract(x) #2826

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

amdrexu
Copy link
Contributor

@amdrexu amdrexu commented Nov 20, 2023

This change reverts the PR
#2804. After SPIR-V workgroup discussed the issues of fract(x), they decide to align fract(-0.0), fract(-INF), and fract(INF) with DXIL's definitions. Our original implementation is fine enough to meet the spec requirements.

This change reverts the PR
GPUOpen-Drivers#2804. After SPIR-V workgroup
discussed the issues of fract(x), they decide to align fract(-0.0),
fract(-INF), and fract(INF) with DXIL's definitions. Our original
implementation is fine enough to meet the spec requirements.
@amdrexu amdrexu requested a review from a team as a code owner November 20, 2023 06:58
@amdvlk-admin
Copy link

Test summary for commit bcf1bb0

CTS tests (Failed: 1/138378)
  • Built with version 1.3.5.2
  • Ubuntu navi3x, Srdcvk
    • Passed: 35162/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34001/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35241/69215 (50.9%)
    • Failed: 1/69215 (0.0%)

      Failures:

      FAILURE: dEQP-VK.fragment_shading_barycentric.data.provoking_first.dynamic.triangle_list_with_adjacency.type.int
      Stack trace: Flake
      

    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@amdvlk-admin
Copy link

Test summary for commit bcf1bb0

CTS tests (Failed: 0/138378)
  • Built with version 1.3.5.2
  • Ubuntu navi3x, Srdcvk
    • Passed: 35162/69163 (50.8%)
    • Failed: 0/69163 (0.0%)
    • Not Supported: 34001/69163 (49.2%)
    • Warnings: 0/69163 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@amdrexu amdrexu merged commit 5011159 into GPUOpen-Drivers:dev Nov 21, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants