-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement new functions from gpurt #2822
Conversation
Add AmdTraceRayGetKnownSetRayFlags/AmdTraceRayGetKnownUnsetRayFlags implementations
Test summary for commit 2b38a27CTS tests (Failed: 0/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Are we not analyzing constant TraceRay flags in LLPC, and optimize Traversal for it? |
this PR is originated from internal project souce. |
We aren't so far, I suppose this would rely on Nicolai's internal proposal about library. |
Interesting.
Only when compiling libraries, correct? For full pipelines, we should have everything we need available. |
Oh yes, it should be doable for full pipelines for now. |
A full pipeline can be very large with thousands of shaders. Probably not good idea to iterate every shader for constant flags analysis. |
retest this please |
Test summary for commit 62b90cfCTS tests (Failed: 0/138443)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we certainly should apply such optimizations in the future, but the point of this PR is primarily to allow us to have the GPURT change move forward. LGTM.
Add AmdTraceRayGetKnownSetRayFlags/AmdTraceRayGetKnownUnsetRayFlags implementations