Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new functions from gpurt #2822

Merged
merged 2 commits into from
Nov 20, 2023
Merged

Implement new functions from gpurt #2822

merged 2 commits into from
Nov 20, 2023

Conversation

jiaolu
Copy link
Contributor

@jiaolu jiaolu commented Nov 17, 2023

Add AmdTraceRayGetKnownSetRayFlags/AmdTraceRayGetKnownUnsetRayFlags implementations

Add AmdTraceRayGetKnownSetRayFlags/AmdTraceRayGetKnownUnsetRayFlags
implementations
@jiaolu jiaolu requested a review from a team as a code owner November 17, 2023 07:06
@amdvlk-admin
Copy link

Test summary for commit 2b38a27

CTS tests (Failed: 0/138443)
  • Built with version 1.3.5.2
  • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@jasilvanus
Copy link
Contributor

Are we not analyzing constant TraceRay flags in LLPC, and optimize Traversal for it?

@jiaolu
Copy link
Contributor Author

jiaolu commented Nov 17, 2023

Are we not analyzing constant TraceRay flags in LLPC, and optimize Traversal for it?

this PR is originated from internal project souce.

@LLJJDD
Copy link
Contributor

LLJJDD commented Nov 17, 2023

Are we not analyzing constant TraceRay flags in LLPC, and optimize Traversal for it?

We aren't so far, I suppose this would rely on Nicolai's internal proposal about library.

@jasilvanus
Copy link
Contributor

Are we not analyzing constant TraceRay flags in LLPC, and optimize Traversal for it?

We aren't so far,

Interesting.

I suppose this would rely on Nicolai's internal proposal about library.

Only when compiling libraries, correct? For full pipelines, we should have everything we need available.

@LLJJDD
Copy link
Contributor

LLJJDD commented Nov 17, 2023

I suppose this would rely on Nicolai's internal proposal about library.

Only when compiling libraries, correct? For full pipelines, we should have everything we need available.

Oh yes, it should be doable for full pipelines for now.

@jiaolu
Copy link
Contributor Author

jiaolu commented Nov 17, 2023

For full pipelines, we should have everything we need available.

A full pipeline can be very large with thousands of shaders. Probably not good idea to iterate every shader for constant flags analysis.

@jiaolu
Copy link
Contributor Author

jiaolu commented Nov 17, 2023

retest this please

@amdvlk-admin
Copy link

Test summary for commit 62b90cf

CTS tests (Failed: 0/138443)
  • Built with version 1.3.5.2
  • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we certainly should apply such optimizations in the future, but the point of this PR is primarily to allow us to have the GPURT change move forward. LGTM.

@jiaolu jiaolu merged commit 4a90a56 into GPUOpen-Drivers:dev Nov 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants