Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lgc: fix wrong thread id when group size Y/Z is 1 #2812

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

xazhangAMD
Copy link
Contributor

tidigCompCnt is set to 0 when y and z are 1 and 1 when z is 1. In the random failed case, the group size is 1x1x1, so the y and z ids are just random values.

tidigCompCnt is set to 0 when y and z are 1 and 1 when z is 1. In the
random failed case, the group size is 1x1x1, so the y and z ids are just
random values.
@xazhangAMD xazhangAMD requested a review from a team as a code owner November 9, 2023 20:19
@amdvlk-admin
Copy link

Test summary for commit b0bc114

CTS tests (Failed: 0/138443)
  • Built with version 1.3.5.2
  • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@xazhangAMD xazhangAMD force-pushed the fix_threadid_in_group branch 2 times, most recently from 31784f8 to 3462871 Compare November 10, 2023 01:59
@amdvlk-admin
Copy link

Test summary for commit 3462871

CTS tests (Failed: 0/138443)
  • Built with version 1.3.5.2
  • Ubuntu navi3x, Srdcvk
    • Passed: 35211/69228 (50.9%)
    • Failed: 0/69228 (0.0%)
    • Not Supported: 34017/69228 (49.1%)
    • Warnings: 0/69228 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35242/69215 (50.9%)
    • Failed: 0/69215 (0.0%)
    • Not Supported: 33973/69215 (49.1%)
    • Warnings: 0/69215 (0.0%)

@xazhangAMD xazhangAMD merged commit 4320b9c into dev Nov 11, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants