llpc: Fix non-determinism in SpirvLowerRayQuery #2811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In SpirvLowerRayQuery, we generate a unique id for each traceRay call. This id is generated by hasing an increasing ID number, and the name of the module. However, the implementation was instead hashing the binary representation of a StringRef object, thereby hashing a pointer. This resulted in non-deterministic IR being generated.
Test summary for commit bf16fd7CTS tests (Failed: 0/138362)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In SpirvLowerRayQuery, we generate a unique id for each traceRay call. This id is generated by hasing an increasing ID number, and the name of the module.
However, the implementation was instead hashing the binary representation of a StringRef object, thereby hashing a pointer.
This resulted in non-deterministic IR being generated.