Disable Xfb for relocatable compilation.. #2798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On gfx11, Xfb depends on the count of primitive vertex. If UnlinkedStageVertexProcess only contains VS (no TES and GS), the primitive type might be unknown at compiling VS time, so we have to fall back to full pipeline. Currently, We treat Traingle_list as the default value. Therefore, we only disable relocatable compilation when primitive is point or line.
Test summary for commit 6533c5dCTS tests (Failed: 0/137941)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Test summary for commit 30e2770CTS tests (Failed: 0/137941)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
nhaehnle
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On gfx11, Xfb depends on the count of primitive vertex. If
UnlinkedStageVertexProcess only contains VS (no TES and GS),
the primitive type might be unknown at compiling VS time, so
we have to fall back to full pipeline.
Currently, We treat Traingle_list as the default value. Therefore,
we only disable relocatable compilation when primitive is point or
line.