Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 64-bit buffer atomic cmpswap workaround #2792

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Remove 64-bit buffer atomic cmpswap workaround #2792

merged 1 commit into from
Nov 3, 2023

Conversation

jayfoad
Copy link
Member

@jayfoad jayfoad commented Oct 30, 2023 •
edited
Loading

Remove a special case for 64-bit buffer atomic cmpswap which is not
required when the LLVM backend supports codegen for this operation.

Draft, waiting for LLVM backend support: llvm/llvm-project#70475

@jayfoad jayfoad force-pushed the 64-bit-atomic-buffer-atomic-cmpswap branch from 0404a39 to c5a206a Compare October 30, 2023 15:56
@jayfoad jayfoad changed the title 64 bit atomic buffer atomic cmpswap Remove 64-bit buffer atomic cmpswap workaround Oct 30, 2023
@amdvlk-admin
Copy link

Test summary for commit c5a206a

CTS tests (Failed: 8/138020)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35397/69018 (51.3%)
    • Failed: 4/69018 (0.0%)

      Failures:

      FAILURE: dEQP-VK.glsl.atomic_operations.comp_swap_signed64bit_compute
Stack trace: Fail

FAILURE: dEQP-VK.glsl.atomic_operations.comp_swap_signed64bit_fragment
Stack trace: Fail

FAILURE: dEQP-VK.glsl.atomic_operations.comp_swap_unsigned64bit_compute
Stack trace: Fail

FAILURE: dEQP-VK.glsl.atomic_operations.comp_swap_unsigned64bit_vertex
Stack trace: Fail

    • Not Supported: 33617/69018 (48.7%)
    • Warnings: 0/69018 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35420/69002 (51.3%)
    • Failed: 4/69002 (0.0%)

      Failures:

      FAILURE: dEQP-VK.glsl.atomic_operations.comp_swap_signed64bit_compute
Stack trace: Fail

FAILURE: dEQP-VK.glsl.atomic_operations.comp_swap_signed64bit_fragment
Stack trace: Fail

FAILURE: dEQP-VK.glsl.atomic_operations.comp_swap_unsigned64bit_compute
Stack trace: Fail

FAILURE: dEQP-VK.glsl.atomic_operations.comp_swap_unsigned64bit_vertex
Stack trace: Fail

    • Not Supported: 33578/69002 (48.7%)
    • Warnings: 0/69002 (0.0%)

nhaehnle
nhaehnle approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jayfoad jayfoad marked this pull request as ready for review November 3, 2023 13:52
@jayfoad jayfoad requested a review from a team as a code owner November 3, 2023 13:52
@jayfoad
Remove 64-bit buffer atomic cmpswap workaround
cd25029 
Remove a special case for 64-bit buffer atomic cmpswap which is not
required when the LLVM backend supports codegen for this operation.
@jayfoad jayfoad force-pushed the 64-bit-atomic-buffer-atomic-cmpswap branch from c5a206a to cd25029 Compare November 3, 2023 13:53
@jayfoad
Copy link
Member Author

jayfoad commented Nov 3, 2023

retest this please

1 similar comment
@dstutt
Copy link
Member

dstutt commented Nov 3, 2023

retest this please

@amdvlk-admin
Copy link

Test summary for commit cd25029

CTS tests (Failed: 0/137941)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35352/68939 (51.3%)
    • Failed: 0/68939 (0.0%)
    • Not Supported: 33587/68939 (48.7%)
    • Warnings: 0/68939 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35424/69002 (51.3%)
    • Failed: 0/69002 (0.0%)
    • Not Supported: 33578/69002 (48.7%)
    • Warnings: 0/69002 (0.0%)

@jayfoad jayfoad merged commit 07222f7 into GPUOpen-Drivers:dev Nov 3, 2023
9 checks passed
@jayfoad jayfoad deleted the 64-bit-atomic-buffer-atomic-cmpswap branch November 3, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhaehnle nhaehnle nhaehnle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jayfoad @amdvlk-admin @dstutt @nhaehnle