Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lgc: add CreateFDot2 to expose amdgcn_fdot2 to the client #2788

Merged
merged 1 commit into from
Oct 31, 2023
Merged

lgc: add CreateFDot2 to expose amdgcn_fdot2 to the client #2788

merged 1 commit into from
Oct 31, 2023

Conversation

xazhangAMD
Copy link
Contributor

No description provided.

@xazhangAMD xazhangAMD requested a review from a team as a code owner October 27, 2023 21:04
@amdvlk-admin
Copy link

Test summary for commit f182bdb

CTS tests (Failed: 0/138020)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35401/69018 (51.3%)
    • Failed: 0/69018 (0.0%)
    • Not Supported: 33617/69018 (48.7%)
    • Warnings: 0/69018 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35424/69002 (51.3%)
    • Failed: 0/69002 (0.0%)
    • Not Supported: 33578/69002 (48.7%)
    • Warnings: 0/69002 (0.0%)

@amdvlk-admin
Copy link

Test summary for commit 05ba49d

CTS tests (Failed: 0/138020)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35401/69018 (51.3%)
    • Failed: 0/69018 (0.0%)
    • Not Supported: 33617/69018 (48.7%)
    • Warnings: 0/69018 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35424/69002 (51.3%)
    • Failed: 0/69002 (0.0%)
    • Not Supported: 33578/69002 (48.7%)
    • Warnings: 0/69002 (0.0%)

@amdvlk-admin
Copy link

Test summary for commit cb98b4e

CTS tests (Failed: 0/137941)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 35352/68939 (51.3%)
    • Failed: 0/68939 (0.0%)
    • Not Supported: 33587/68939 (48.7%)
    • Warnings: 0/68939 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 35423/69002 (51.3%)
    • Failed: 0/69002 (0.0%)
    • Not Supported: 33579/69002 (48.7%)
    • Warnings: 0/69002 (0.0%)

nhaehnle
nhaehnle approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes I wonder if for stuff like this, we couldn't just create the intrinsic directly in the frontend. But it's fine as-is.

@xazhangAMD xazhangAMD merged commit ec7a18a into dev Oct 31, 2023
14 checks passed
@xazhangAMD xazhangAMD deleted the fdot_f32_f16 branch October 31, 2023 02:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhaehnle nhaehnle nhaehnle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xazhangAMD @amdvlk-admin @nhaehnle