Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update lgc test due to upgrading to gfx1010 #2773

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Update lgc test due to upgrading to gfx1010 #2773

merged 2 commits into from
Oct 25, 2023

Conversation

xuechen417
Copy link
Contributor

No description provided.

@xuechen417 xuechen417 requested a review from a team as a code owner October 19, 2023 05:35
@amdvlk-admin
Copy link

Test summary for commit b3f4538

CTS tests (Failed: 0/138994)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 41144/69503 (59.2%)
    • Failed: 0/69503 (0.0%)
    • Not Supported: 28359/69503 (40.8%)
    • Warnings: 0/69503 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 41178/69491 (59.3%)
    • Failed: 0/69491 (0.0%)
    • Not Supported: 28313/69491 (40.7%)
    • Warnings: 0/69491 (0.0%)

nhaehnle
nhaehnle reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

lgc/test/BuiltIns/cs-subgroupid.lgc Show resolved Hide resolved
lgc/test/BuiltIns/cs-subgrouplocalinvocationid.lgc Show resolved Hide resolved
lgc/test/BuiltIns/cs-subgroupsize.lgc Show resolved Hide resolved
lgc/test/FetchShaderSingleInput.lgc Show resolved Hide resolved
lgc/test/ElfRelocationAndNote.lgc Show resolved Hide resolved
@xuechen417
Update lgc test due to -mcpu upgrading to gfx1010
4483b12 
- Upgrade `gpuName` default value from gfx802 to gfx1010.
- Update lgc test with -mcpu=gfx1010.
(cherry picked from commit 671d1d1d4024ff41edbcfe535aa28d77fefd45e3)
@xuechen417
Upgrade lgc units default gpu name to gfx1010
2d32715 
(cherry picked from d743c53d38d7dc718d941c9a7a9ff9f17b255748)
xuechen417
xuechen417 commented Oct 23, 2023
View reviewed changes
Copy link
Contributor Author

@xuechen417 xuechen417 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

V1: Update some tests with duplicated testing commands.

lgc/test/BuiltIns/cs-subgroupid.lgc Show resolved Hide resolved
lgc/test/BuiltIns/cs-subgrouplocalinvocationid.lgc Show resolved Hide resolved
lgc/test/BuiltIns/cs-subgroupsize.lgc Show resolved Hide resolved
lgc/test/ElfRelocationAndNote.lgc Show resolved Hide resolved
lgc/test/FetchShaderSingleInput.lgc Show resolved Hide resolved
nhaehnle
nhaehnle approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@nhaehnle nhaehnle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xuechen417
Copy link
Contributor Author

retest this please

@xuechen417
Copy link
Contributor Author

The PR only modified lgc tests and had no impact on PipelineVsFs_ConstantData_Vs2Fs1.pipe

@amdvlk-admin
Copy link

Test summary for commit 2d32715

CTS tests (Failed: 0/138995)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 41144/69504 (59.2%)
    • Failed: 0/69504 (0.0%)
    • Not Supported: 28360/69504 (40.8%)
    • Warnings: 0/69504 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 41177/69491 (59.3%)
    • Failed: 0/69491 (0.0%)
    • Not Supported: 28314/69491 (40.7%)
    • Warnings: 0/69491 (0.0%)

@qiaojbao qiaojbao closed this Oct 24, 2023
@qiaojbao qiaojbao reopened this Oct 24, 2023
@amdvlk-admin
Copy link

Test summary for commit 2d32715

CTS tests (Failed: 0/138994)
  • Built with version 1.3.5.2
    • Ubuntu navi3x, Srdcvk
    • Passed: 41144/69503 (59.2%)
    • Failed: 0/69503 (0.0%)
    • Not Supported: 28359/69503 (40.8%)
    • Warnings: 0/69503 (0.0%)
    Ubuntu navi2x, Srdcvk
    • Passed: 41177/69491 (59.3%)
    • Failed: 0/69491 (0.0%)
    • Not Supported: 28314/69491 (40.7%)
    • Warnings: 0/69491 (0.0%)

@xuechen417 xuechen417 merged commit 8085771 into GPUOpen-Drivers:dev Oct 25, 2023
9 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhaehnle nhaehnle nhaehnle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xuechen417 @amdvlk-admin @nhaehnle @qiaojbao