Run check-continuations in CI #2720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiaojbao
changed the title
qiaojbao
changed the title
|
Doesn't actually pass. Part apart from that it LGTM. |
|
Rebased and now also runs |
Test summary for commit a22df28CTS tests (Failed: 0/137949)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
nhaehnle
previously approved these changes
Oct 26, 2023
The SavedRegisterValues vector was accessed after its allocation went out of scope, make the value owned to prevent that.
Add check-continuations to the GitHub Actions workflows.
|
Sanitizers found the first bug in continuations :) |
Test summary for commit 3b34a48CTS tests (Failed: 0/137941)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
nhaehnle
previously approved these changes
Oct 27, 2023
The first loop in the post-process pass should only handle start functions, not resume functions as their arguments are different. Fix this by filtering out resume functions. This fixes a regression introduced in the lgc.rt.shaderstage patch. It asserted in a registercount test.
|
Cherry-pick an internal patch to fix tests. |
|
retest this please |
Test summary for commit 09ef5e5CTS tests (Failed: 0/138020)
Ubuntu navi3x, SrdcvkUbuntu navi2x, Srdcvk |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add check-continuations to the GitHub Actions workflows.