Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve inline documentation of ContributionType class #500

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Improve inline documentation of ContributionType class #500

merged 3 commits into from
Apr 19, 2023

Conversation

SlowMo24
Copy link
Contributor

@SlowMo24 SlowMo24 commented Mar 27, 2023 •
edited by tyrasd
Loading

This PR starts working on #499

First step: update the documentation.

@SlowMo24 SlowMo24 requested a review from tyrasd March 27, 2023 11:40
@tyrasd
Copy link
Member

tyrasd commented Apr 5, 2023

Closes #499

Does it, though? 😉

@tyrasd tyrasd added the documentation Readmes, Javadoc, Tutorials, etc. label Apr 5, 2023
@SlowMo24
Copy link
Contributor Author

SlowMo24 commented Apr 6, 2023

Does it, though? wink

not yet, your right. But the goal would be to do that in this PR, I guess. Updated the description.

@SlowMo24
Copy link
Contributor Author

after our discussion in the last meeting: This PR is WIP to solve #499 but it is done concerning the single documentation update it does. I will not be able to work on #499 so feel free to merge this and leave #499 open (my suggestion).

@tyrasd tyrasd changed the title 🚧: feat:Update ContributionType class Improve inline documentation of ContributionType class Apr 19, 2023
@tyrasd tyrasd merged commit e4daab6 into master Apr 19, 2023
@tyrasd tyrasd deleted the fix_contirb_docu branch April 19, 2023 09:12
ConstantinNicolai pushed a commit that referenced this pull request Oct 11, 2023
@SlowMo24 @ConstantinNicolai
docs: Improve inline documentation of ContributionType class (#500)
febfe48 
* api fix javadoc for OSMContribution.is()
* fix grammar and typos in OSMContribution javadoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyrasd tyrasd tyrasd approved these changes

Assignees
No one assigned
Labels
documentation Readmes, Javadoc, Tutorials, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SlowMo24 @tyrasd