Explicitly use iso_c_binding types #2531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds two explicit `use` of two `iso_c_binding` types that currently are brought in (inadvertently) via `use ESMF`. This has been fixed in ESMF upstream (`develop` at least), so this fix is in anticipation of ESMF 8.7 testing.
mathomp4
added
the
0 Diff
tclune
previously approved these changes
Jan 16, 2024
tclune
approved these changes
Jan 18, 2024
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two explicit
useof twoiso_c_bindingtypes that currently are brought in (inadvertently) viause ESMF. This has been fixed in ESMF upstream (developat least), so this fix is in anticipation of ESMF 8.7 testing.This was found in test attempts at fixing esmf-org/esmf#209 by trying some ESMF hacks.
Related Issue
Motivation and Context
The first time someone tries building MAPL with ESMF 8.7 snapshots, things won't compile. Now they will.
How Has This Been Tested?
MAPL built.
Types of changes
Checklist: