-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update file specs to match M21C #72
Merged
gmao-rreichle
merged 14 commits into
develop
from
feature/rreichle/update_exports_to_M21C_filespecs
Jan 9, 2025
Merged
update file specs to match M21C #72
gmao-rreichle
merged 14 commits into
develop
from
feature/rreichle/update_exports_to_M21C_filespecs
Jan 9, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- update LONG_NAME attributes (GEOS_EnsGridComp.F90) - update lnd Collection in HISTORY template (GEOSldas_HIST.rc)
… GEOS_LandAssimGridComp.F90, GEOS_ExportCatchIncrGridComp.F90, tile_bin2nc4.F90)
gmao-rreichle
added
documentation
Improvements or additions to documentation
cleanup
output
post-processing
labels
Dec 17, 2024
gmao-rreichle
commented
Dec 17, 2024
…IST.rc, tile_bin2nc4.F90)
…nsistency w/ M21C (tile_bin2nc4.F90)
…for lnd Collections (GEOSldas_HIST.rc)
…eady for CatchCN], fixed comment character
…chGridComp (GEOS_EnsGridComp.F90, GEOS_LandAssimGridComp.F90, GEOSldas_HIST.rc, process_hist.csh)
biljanaorescanin
approved these changes
Jan 9, 2025
gmao-rreichle
deleted the
feature/rreichle/update_exports_to_M21C_filespecs
branch
January 9, 2025 21:09
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates GEOSldas to the M21C file specs:
PARTIALLY COMPLETE:
NOT DONE:
For the M21C file specs, see M21C ADAS release GEOSadas-5.30.3-M21C-6 (latest as of 17-Dec-2024). Specifically, the file specs are encoded in:
Draft (!!!) M21C file specs doc: e5303_m21c_filespec_ctl_cycle.pdf
TESTING:
GEOSldas branch for testing:
feature/rreichle/TEST_update_exports_to_M21C_filespecs
@gmao-rreichle confirmed 0-diff for data in LDAS tests after commit e1add91
(Note that the nc4 comparison must account for the variable name changes in the "lnd" output; I used
lnd_rename.txt for changing the new variable names back to the old ones for comparison with the baseline -- note the hardcoded input and output file names in lnd_rename.txt.)
The latest commit c9ec191 adds another layer of complexity and requires editing the HISTORY.rc files associated with the GLOBAL/model, GLOBAL/assim, and GLOBALCS/assim tests. Specifically, TSOIL[x]TILE needs to be replaced with TP[x] in these HISTORY.rc files.
@biljanaorescanin successfully tested all standard Intel test cases and DEBUGCONUS. Merging PR while AGG and GNU tests are proceeding under the assumption that these will be fine (because there are no build errors in CI and because GNU and AGG were tested by @gmao-rreichle after the penultimate commit).