Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update file specs to match M21C #72

Merged

Conversation

gmao-rreichle
Copy link
Collaborator

@gmao-rreichle gmao-rreichle commented Dec 16, 2024

This PR updates GEOSldas to the M21C file specs:

  • Updates LONG_NAME attributes in the EnsGridComp to match those of M21C.
  • Updates HISTORY template (GEOSldas_HIST.rc) with variable names (SHORT_NAME) used in M21C.
  • Updates tile_bin2nc4.F90 to match M21C variable names and descriptions.

PARTIALLY COMPLETE:

  • Land constants file. Variables not (yet) in ENSAVG GridComp, but should be ok when written from Catch GridComp.

NOT DONE:

  • M21C output file name template.

For the M21C file specs, see M21C ADAS release GEOSadas-5.30.3-M21C-6 (latest as of 17-Dec-2024). Specifically, the file specs are encoded in:

GEOSgcm_App      tag: v1.9.6+R21C_v1.0.6
GEOSgcm_GridComp tag: v1.18.1+R21C_v1.0.4

Draft (!!!) M21C file specs doc: e5303_m21c_filespec_ctl_cycle.pdf


TESTING:

GEOSldas branch for testing: feature/rreichle/TEST_update_exports_to_M21C_filespecs

@gmao-rreichle confirmed 0-diff for data in LDAS tests after commit e1add91
(Note that the nc4 comparison must account for the variable name changes in the "lnd" output; I used
lnd_rename.txt for changing the new variable names back to the old ones for comparison with the baseline -- note the hardcoded input and output file names in lnd_rename.txt.)

The latest commit c9ec191 adds another layer of complexity and requires editing the HISTORY.rc files associated with the GLOBAL/model, GLOBAL/assim, and GLOBALCS/assim tests. Specifically, TSOIL[x]TILE needs to be replaced with TP[x] in these HISTORY.rc files.

@biljanaorescanin successfully tested all standard Intel test cases and DEBUGCONUS. Merging PR while AGG and GNU tests are proceeding under the assumption that these will be fine (because there are no build errors in CI and because GNU and AGG were tested by @gmao-rreichle after the penultimate commit).

- update LONG_NAME attributes (GEOS_EnsGridComp.F90)
- update lnd Collection in HISTORY template (GEOSldas_HIST.rc)
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner December 16, 2024 22:49
@gmao-rreichle gmao-rreichle self-assigned this Dec 16, 2024
@gmao-rreichle gmao-rreichle marked this pull request as draft December 17, 2024 19:58
@gmao-rreichle gmao-rreichle added documentation Improvements or additions to documentation cleanup output post-processing labels Dec 17, 2024
@gmao-rreichle gmao-rreichle marked this pull request as ready for review January 9, 2025 21:07
@gmao-rreichle gmao-rreichle merged commit 1134dff into develop Jan 9, 2025
15 checks passed
@gmao-rreichle gmao-rreichle deleted the feature/rreichle/update_exports_to_M21C_filespecs branch January 9, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0-diff cleanup documentation Improvements or additions to documentation output post-processing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants