Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving catchcn CO2 file to bcs dir #481

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Conversation

biljanaorescanin
Copy link
Contributor

Addressing issue #471.
This PR is using CO2 file needed for CatchCN offline simulations from boundary conditions area.

To accommodate for this in "legacy_bcs" area we added this file to these boundary conditions versions.
Icarus-NLv3; Icarus ; Ganymed-4_0

@gmao-jkolassa do you need me to add this to any other boundary conditions version?
I will add one more PR to GEOSldas to change path for ldas_setup as well.

@biljanaorescanin biljanaorescanin added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Jun 22, 2023
@biljanaorescanin biljanaorescanin changed the title Moving catchcn co2 file to bcs dir Moving catchcn CO2 file to bcs dir Jun 22, 2023
@gmao-jkolassa
Copy link
Contributor

Thanks @biljanaorescanin ! Could you please also add this file to the Heracles-NL boundary conditions version, as that is what some of the Catchment-CN4.0 simulations are using. Thanks!

@biljanaorescanin
Copy link
Contributor Author

@gmao-jkolassa I just added Heracles-NL its good I've asked I didn't think anyone uses that set.

@mathomp4 My understanding is that NAS sync's to DISCOVER, is that correct? If it is than this should be there with first rsync that happens? Since we already moved BCS files to be used from legacy_bcs path and not ltakacs area.

@mathomp4
Copy link
Member

@mathomp4 My understanding is that NAS sync's to DISCOVER, is that correct? If it is than this should be there with first rsync that happens? Since we already moved BCS files to be used from legacy_bcs path and not ltakacs area.

It's the other way. We sync discover to NAS. So, if this is in whatever BCSDIR is on discover, we should get it at NAS. At the moment, we probably don't have every BCs directory at NAS because we are in a space-crunch. But if things fail, we can figure it out.

@gmao-rreichle gmao-rreichle marked this pull request as ready for review June 28, 2023 18:35
@gmao-rreichle gmao-rreichle requested a review from a team as a code owner June 28, 2023 18:35
@gmao-rreichle gmao-rreichle added 0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.) and removed 0 diff The changes in this pull request have verified to be zero-diff with the target branch. labels Jun 28, 2023
@sdrabenh sdrabenh merged commit 5ff1e13 into develop Jul 3, 2023
@sdrabenh sdrabenh deleted the feature/borescan_catchcn_co2 branch July 3, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 diff trivial The changes in this pull request are trivially zero-diff (documentation, build failure, &c.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants