-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
achem CO and GAAS aod updates; Lopez lightning revision #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR updates the CircleCI config the v2 orb. This has updated needed for changes in GEOSgcm_App and Baselibs
…revised version of CEDS that is now being used by GOCART
Update CircleCI to use Orb v2
This PR updates the ESMF CMake target to `ESMF::ESMF` which is the correct canonical target name for ESMF. This is necessary for Spack compatibility. NOTE: This requires ESMF 8.6.1 or later.
…rget Update ESMF CMake target to ESMF::ESMF
…em_develop Update CEDS emissions for CO in achem (develop)
…ions Feature/gaas fix for amip emissions
…ightning Lopez lightning revisions
…for_1.15.0 edit changelog for v1.15.0
mathomp4
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two non-zero-diff changes:
From #279 : in achem, CO emissions from CEDS are now revised to correct the seasonal cycle; this corresponds to the GOCART PR 283
From #282 : the ExtData entries in GAAS for aod_a, aod_f and aod_k now match the version in OPS, averting a crash during Replay. NOTES: This depends on the proper assignment of REPLAY_ANA_EXPID and REPLAY_ANA_LOCATION in AGCM.rc, and some clever code in the run script, but it works. Caveats regarding GAAS_GridComp_ExtData.yaml: (i) "update_offset: PT450S" will need to be changed if the timestep changes, (ii) the 'fail_on_missing_file' flag for each export should probably be set to TRUE for hindcast simulations, to help guard against inadvertent mistakes.
Zero-diff change:
The LOPEZ lightning scheme has been revised, and is now the default scheme. This affects GMI simulations, but not PCHEM ones.