Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option GPU_PHYSICS #322

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

Add option GPU_PHYSICS #322

wants to merge 7 commits into from

Conversation

pchakraborty
Copy link
Collaborator

Added cmake option GPU_PHYSICS with a default value of OFF. If ON, find OpenACC.

@pchakraborty pchakraborty requested a review from a team as a code owner June 26, 2023 13:17
@github-actions
Copy link

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Please add one so that the PR can be merged.

1 similar comment
@github-actions
Copy link

This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled. Please add one so that the PR can be merged.

@pchakraborty pchakraborty added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Jun 26, 2023
@pchakraborty
Copy link
Collaborator Author

Would the option GPU_PHYSICS qualify as a significant change? I believe so, but wanted to check before updating CHANGELOG.

@mathomp4
Copy link
Member

Would the option GPU_PHYSICS qualify as a significant change? I believe so, but wanted to check before updating CHANGELOG.

@pchakraborty Yeah, I think so. Can you add a changelog entry and then I'll merge in?

@mathomp4 mathomp4 mentioned this pull request Jun 26, 2023
Draft
@tclune tclune self-requested a review June 28, 2023 19:14
tclune
tclune previously approved these changes Jun 28, 2023
View reviewed changes
@pchakraborty pchakraborty marked this pull request as draft June 30, 2023 02:38
@pchakraborty
Copy link
Collaborator Author

@mathomp4 Is this what you meant here? I’m not ready to have this merged it, just wanted to run it by you.

@mathomp4
Copy link
Member

mathomp4 commented Jul 3, 2023

@mathomp4 Is this what you meant here? I’m not ready to have this merged it, just wanted to run it by you.

@pchakraborty I think so, yes! Just in case we have another compiler at some point with these options :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tclune tclune tclune left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
0 diff The changes in this pull request have verified to be zero-diff with the target branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pchakraborty @mathomp4 @tclune