Fixed "No External Storage Permission" on first run and bad state of application #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oved to requestpermissionsresult. Also finish activity when user denied.
Remzoo
changed the title
|
Here is short video illustrating problem. Sorry for Polish language, but as you can see I pressed Accept ("Zezwól") but the application showed "No external Storage Permission". This error occur rather on fast smartphones than slower. https://drive.google.com/file/d/1hrBfYtrCx0pxjQY7Nk13mqxRaXCsbkUz/view |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed toast about no permission to storage on first run and moved to onRequestPermissionsResult.
When user runs application for the first time it is obvious application don't have permissions to storage. This information makes users confusing. It is important to notice that ContextCompat.requestPermissions is running on another thread. Setting variable configFileError right after calling requestPermissions function may cause bad state. In this case error flag will be setting faster than dialog show up.
Additionally activity will be finished when user declined.