Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Refactor] DropDownOption 에 대해서 context 로 분리 #93
[Refactor] DropDownOption 에 대해서 context 로 분리 #93
Changes from 14 commits
8f751e6
4cf6973
00c26bf
5c57c1a
69c641d
42500ff
829f096
ea56104
dc8c589
6b3db85
6574310
4343ad0
88f7fce
c5edc59
3c38d6b
b001317
504878c
f8527b2
eb86299
fdcb756
8be18f5
2b66ec1
ad51ddb
50d1ee5
d772386
c2ad801
b9072e3
6ca0434
6440016
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p3;
renderCustomTrigger에서도 cloneElement가 아니라 context api 방식으로 해결해볼 수 있을 거 같다는 생각이 드는데, 별도의 컴포넌트로 분리 후 context api 적용하도록 개선해보면 좋지 않을까 싶습니다!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
context api 를 적용하려면 trigger 외부에 div 같은 엘리먼트로 하나 감싸서 프로퍼티를 전달해주어야 하는데 요렇게 되면 의도하지 않은 외부 div 가 돔에 생겨서 스타일링에 영향을 줄 수도 있을 것 같은데 어떻게 생각하시나용?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
음 그럴 수도 있겠네요!
당장은 best practice가 뭔지 잘 모르겠어서 조금 더 고민해봐야 할 거 같아요!
추후에 더 좋은 방법이 생각난다면 개선해봐도 좋을 거 같은...