Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Stepper 컴포넌트를 구현해요. #65

Merged
merged 16 commits into from
Jul 5, 2024
Merged

[Feature] Stepper 컴포넌트를 구현해요. #65

merged 16 commits into from
Jul 5, 2024

Conversation

eugene028
Copy link
Collaborator

@eugene028 eugene028 commented Jun 27, 2024 •
edited by ghdtjgus76
Loading

🎉 변경 사항

대시보드에서 ProgressBar가 필요하기 때문에, 디자인 시스템에 구현해두는 것이 필요할 것 같아서 구현하였어요.

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

현재 a11y테스트 버전 문제인지,, wow-ui package에 @playwright/test가 없으면 테스트가 터지는 문제가 있어서, ProgressBar 컴포넌트 구현에 같이 껴 넣었어용

@eugene028 eugene028 self-assigned this Jun 27, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-yzvggrmghb.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-boptdvmnsp.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-oejhpzelbo.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-zzdhpvwhpo.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-rldqeospsg.chromatic.com/

ghdtjgus76
ghdtjgus76 reviewed Jun 29, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!
혹시... 이 PR이랑 이전에 올려주신 PR 타이틀 컨벤션에 맞게 수정해주실 수 있을까요...?

packages/wow-ui/rollup.config.js Outdated Show resolved Hide resolved
packages/wow-ui/src/components/ProgressBar/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/ProgressBar/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/ProgressBar/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/ProgressBar/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/ProgressBar/ProgressBar.stories.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/ProgressBar/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/ProgressBar/ProgressBarLabel.tsx Outdated Show resolved Hide resolved
@eugene028 eugene028 changed the title [Feature] : ProgressBar 컴포넌트를 구현해요. [Feature] ProgressBar 컴포넌트를 구현해요. Jun 29, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-ttnibuwshm.chromatic.com/

SeieunYoo
SeieunYoo reviewed Jun 30, 2024
View reviewed changes
Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨어요!!👍

++) 저는 프로그래스바라고 했을 때 요런 프로그래스의 정도를 나타내는 UI 의 컴포넌트를 생각했는데
image

와우 시스템의 프로그래스바 컴포넌트는 스텝을 나타내는 Stepper 의 형태에 더 가까운 것 같아요..! 그래서 Stepper 라는 컴포넌트 네이밍은 어떨지 의견 드려봅니당,,~ (바꾸게 된다면 디자이너분과 협의도 필요할 것 같아유)

mui stepper
chakra stepper

packages/wow-ui/src/components/ProgressBar/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/ProgressBar/index.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/ProgressBar/index.tsx Outdated Show resolved Hide resolved
@eugene028
Copy link
Collaborator Author

수고 많으셨어요!!👍

++) 저는 프로그래스바라고 했을 때 요런 프로그래스의 정도를 나타내는 UI 의 컴포넌트를 생각했는데 image

와우 시스템의 프로그래스바 컴포넌트는 스텝을 나타내는 Stepper 의 형태에 더 가까운 것 같아요..! 그래서 Stepper 라는 컴포넌트 네이밍은 어떨지 의견 드려봅니당,,~ (바꾸게 된다면 디자이너분과 협의도 필요할 것 같아유)

mui stepper chakra stepper

좋은 래퍼런스 감사해요! 요건 예영님께 문의드려놓았고 답변 오면 의견 조율하여 처리하도록 하겠습니당!

@eugene028
Copy link
Collaborator Author

@ghdtjgus76 @SeieunYoo 코드리뷰 반영 완료임닷 😃

@eugene028 eugene028 changed the title [Feature] ProgressBar 컴포넌트를 구현해요. [Feature] Stepper 컴포넌트를 구현해요. Jul 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-vtpitnkuld.chromatic.com/

SeieunYoo
SeieunYoo approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨어용~~👍
Stepper 포함해서 wow-ui에 배포하려면 changeset도 추가해주심 좋을 것 같아요!!

ghdtjgus76
ghdtjgus76 reviewed Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

스토리 파일명이나 ProgressBar 변수 남아있는 부분만 Stepper로 변경 부탁드려요~

@eugene028
Copy link
Collaborator Author

스토리 파일명이나 ProgressBar 변수 남아있는 부분만 Stepper로 변경 부탁드려요~

아공 꼼꼼하지 못했네요..! 고쳐두었습니다 🥹

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-limwgysfne.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-zwrjulkfxs.chromatic.com/

ghdtjgus76
ghdtjgus76 approved these changes Jul 5, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

웹접근성 테스트 실패하는 부분만 수정 부탁드려요...🥲

@eugene028 eugene028 merged commit bd5369b into main Jul 5, 2024
3 checks passed
@eugene028 eugene028 deleted the feature/progressBar-component branch July 5, 2024 16:49
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 5, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-pbauuxykmk.chromatic.com/

@ghdtjgus76 ghdtjgus76 linked an issue Jul 26, 2024 that may be closed by this pull request
[Feature] Progress Bar 컴포넌트 구현 #64
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeieunYoo SeieunYoo SeieunYoo approved these changes

@ghdtjgus76 ghdtjgus76 ghdtjgus76 approved these changes

@hamo-o hamo-o Awaiting requested review from hamo-o hamo-o is a code owner

@kongnayeon kongnayeon Awaiting requested review from kongnayeon

Assignees

@eugene028 eugene028

Labels
👩‍💻 리뷰 남겨주세요!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Progress Bar 컴포넌트 구현
3 participants
@eugene028 @ghdtjgus76 @SeieunYoo