Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] Picker 컴포넌트 QA사항 반영 #154

Merged
merged 7 commits into from
Sep 4, 2024
Merged

[Fix] Picker 컴포넌트 QA사항 반영 #154

merged 7 commits into from
Sep 4, 2024

Conversation

hamo-o
Copy link
Member

@hamo-o hamo-o commented Aug 31, 2024 •
edited
Loading

🎉 변경 사항

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-nvpetbnztl.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-madisnjdil.chromatic.com/

@hamo-o hamo-o marked this pull request as ready for review September 3, 2024 07:53
@hamo-o hamo-o linked an issue Sep 3, 2024 that may be closed by this pull request
[Chore] Picker 컴포넌트 QA사항 반영 #156
Closed
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 3, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-toomxihssq.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-nkbthkekdi.chromatic.com/

ghdtjgus76
ghdtjgus76 approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@ghdtjgus76 ghdtjgus76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

SeieunYoo
SeieunYoo approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~

packages/wow-ui/src/components/DropDown/DropDownOption.tsx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-cikeqdwxec.chromatic.com/

@hamo-o hamo-o merged commit c7471ac into main Sep 4, 2024
3 checks passed
@hamo-o hamo-o deleted the fix/date-picker-component branch September 4, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeieunYoo SeieunYoo SeieunYoo approved these changes

@ghdtjgus76 ghdtjgus76 ghdtjgus76 approved these changes

@eugene028 eugene028 Awaiting requested review from eugene028 eugene028 is a code owner

Assignees

@hamo-o hamo-o

Labels
👩‍💻 리뷰 남겨주세요!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Chore] Picker 컴포넌트 QA사항 반영
3 participants
@hamo-o @ghdtjgus76 @SeieunYoo