Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] disabled 버튼 이벤트 막기 #152

Merged
merged 2 commits into from
Aug 30, 2024
Merged

Conversation

hamo-o
Copy link
Member

@hamo-o hamo-o commented Aug 28, 2024

🎉 변경 사항

  • disabled 버튼 이벤트를 막습니다.

🚩 관련 이슈

🙏 여기는 꼭 봐주세요!

  • disabled 속성이 항상 동작하는 것이 아니라서 생긴 문제였습니다. (태그 종류에 따라 다름)
  • type: "button"을 주는 방법도 있었으나, 버튼이 다른 역할을 할 수도 있는데 type: "button"을 강제하는 것보다는 css 속성으로 막아주는 것이 나을 것이라고 판단해 수정했습니다.

Copy link
Contributor

Copy link
Contributor

@hamo-o hamo-o merged commit e3587a3 into main Aug 30, 2024
3 checks passed
@hamo-o hamo-o deleted the fix/button-component-disabled branch August 30, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants