[Fix] aria-pressed 속성 active 대체 및 useButton 훅 삭제 #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamo-o
requested review from
ghdtjgus76,
eugene028 and
SeieunYoo
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 변경 사항
aria-pressed속성이 문제가 되는 것 같아 해당 속성을 삭제했습니다.useButton훅으로 일일이pressed상태관리를 해주었는데,active의사 클래스를 사용하면 그럴 필요 없이pressed상태를 감지할 수 있어 스타일링 기준을active로 대체했습니다. (스타일링 외에는 사용되지 않음)🚩 관련 이슈
🙏 여기는 꼭 봐주세요!