Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] 테이블 컴포넌트 구현 #134

Merged
merged 31 commits into from
Oct 24, 2024
Merged

[Feature] 테이블 컴포넌트 구현 #134

merged 31 commits into from
Oct 24, 2024

Conversation

eugene028
Copy link
Collaborator

@eugene028 eugene028 commented Aug 10, 2024 •
edited
Loading

🎉 변경 사항

테이블 컴포넌트를 구현했어요.
뒤이어 올릴 Pagination 컴포넌트와 함께 사용하게 될 예정이에요.

기존에 <table>관련된 태그를 모두 export 해 사용하는 방식으로 구현하였으나,
사용법이 복잡하고 가독성이 좋지 않아서 data와 그와 관련된 모델을 header로 설정할 수 있도록 개선하였어요.

🚩 관련 이슈

#131

🙏 여기는 꼭 봐주세요!

추후 수강생 관리 페이지 (와우 클래스 어드민) 생성에 필요한 컴포넌트라 얼렁 만들어보았습니다..
사용에 불편함이 있으시다면 먼저 MUI 사용해도 될 것 같아용 (와우클래스 디자인도 그리 되어 있어서..허헛)
스크린샷 2024-09-06 오전 2 23 24

cc. @hamo-o

@eugene028 eugene028 self-assigned this Aug 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-nfdqpzpuwv.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-rycrmmvhwq.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-sjtdqxxbfc.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-jarfnohqnp.chromatic.com/

@eugene028 eugene028 marked this pull request as ready for review September 5, 2024 16:51
@eugene028 eugene028 changed the title [Feat]: 테이블 컴포넌트 구현 [Feature]: 테이블 컴포넌트 구현 Sep 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 5, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-seoqfgamtt.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-tjwdsgyiqs.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-wuthrsmtxh.chromatic.com/

SeieunYoo
SeieunYoo reviewed Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

합성 컴포넌트로 리팩토링 하느라 수고하셨습니다....!😵

+) 스토리북에서 확인했을 때 체크한 table row 의 정렬이 안맞는 부분도 같이 확인해주시면 좋을 거 같습니다~
image

packages/wow-ui/src/components/Table/Td.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Table/TableContext.ts Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Table/Td.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/hooks/useTableCheckState.ts Outdated Show resolved Hide resolved
packages/wow-ui/src/hooks/useCountRow.ts Outdated Show resolved Hide resolved
hamo-o
hamo-o reviewed Oct 4, 2024
View reviewed changes
Copy link
Member

@hamo-o hamo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

packages/wow-ui/src/components/Table/Table.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Table/Table.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Table/Tr.tsx Outdated Show resolved Hide resolved
packages/wow-ui/src/hooks/useTableCheckState.ts Outdated Show resolved Hide resolved
packages/wow-ui/src/hooks/useTableCheckState.ts Outdated Show resolved Hide resolved
@eugene028 eugene028 requested review from SeieunYoo and hamo-o October 9, 2024 13:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-uacmdxakhl.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

🚀 storybook: https://663657b8272769a8d18a5e3f-ihtlzgghzv.chromatic.com/

hamo-o
hamo-o approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@hamo-o hamo-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!!

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 16, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: f129e1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wowds-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-lezpdmgzdr.chromatic.com/

@eugene028 eugene028 requested a review from SeieunYoo October 20, 2024 17:00
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-jpzxvuymda.chromatic.com/

SeieunYoo
SeieunYoo approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@SeieunYoo SeieunYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨습니다..!!! 😂 나머지는 마이너 리뷰라 changeset 관련만 수정해주시면 머지해도 될 거 같습니다~

+) style 네이밍 컨벤션 카멜케이스인지 한번 더 확인해주시면 감사하겠습니다~
image

.changeset/grumpy-llamas-occur.md Outdated Show resolved Hide resolved
packages/wow-ui/src/components/Table/Td.tsx Show resolved Hide resolved
packages/wow-ui/src/hooks/useTableCheckState.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-ufbzfxxjdt.chromatic.com/

@github-actions GitHub Actions
Copy link
Contributor

🚀 storybook: https://663657b8272769a8d18a5e3f-nqppxfaufe.chromatic.com/

@eugene028 eugene028 merged commit 0583f9d into main Oct 24, 2024
3 checks passed
@eugene028 eugene028 deleted the feat/table branch October 24, 2024 15:40
@SeieunYoo SeieunYoo linked an issue Oct 30, 2024 that may be closed by this pull request
[Feature] Table 컴포넌트 구현 #131
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeieunYoo SeieunYoo SeieunYoo approved these changes

@hamo-o hamo-o hamo-o approved these changes

@ghdtjgus76 ghdtjgus76 Awaiting requested review from ghdtjgus76

Assignees

@eugene028 eugene028

Labels
👩‍💻 리뷰 남겨주세요!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Table 컴포넌트 구현
4 participants
@eugene028 @ghdtjgus76 @hamo-o @SeieunYoo