Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Study Controller, Service 추가 #11

Open
wants to merge 22 commits into
base: develop
Choose a base branch
from
Open

Conversation

ybkang1108
Copy link
Collaborator

@ybkang1108 ybkang1108 commented Jan 17, 2025

스터디 생성(수정필요)
스터디 전체 조회
스터디 정보 조회
스터디 삭제

스터디서비스 분리도 해야해요

@ybkang1108 ybkang1108 changed the base branch from main to develop January 17, 2025 07:57
스터디 수정 기능을 service와 controller에 추가
StudyCreateResponse에서 message를 제거하고 id만 반환하도록 함
MessageResponse DTO 제거
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DTO 는 record로 만드는걸로 통일하면 어떨까요
JsonFormat 은 compact constructor 에 작성하면 될거 같아요

dto를 class에서 record로 변경함
- domain에 create 추가
- dto를 record로 변경
StudyDetailResponse와 StudyListResponse 통일
- 스터디장 권한이 필요한 함수는 LeaderStudyService로 분리
- dto 변경에 따른 수정
바뀐 response에 따라 수정함
호환성 문제로 springdoc 버전을 2.5.0에서 2.7.0으로 변경
Copy link
Collaborator

@cmj7271 cmj7271 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 남겼습니다

- AllArgsConstructor 추가
- 불필요한 생성자 제거
service에서 curriculum과 day를 처리하는 로직을 domain으로 옮김
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants