-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Study Controller, Service 추가 #11
Open
ybkang1108
wants to merge
22
commits into
develop
Choose a base branch
from
feature/service-study
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
curriculum, day cascade 설정 추가 delete, detail response dto 수정
cmj7271
reviewed
Jan 17, 2025
cmj7271
reviewed
Jan 17, 2025
src/main/java/com/gdgoc/study_group/study/dto/StudyCreateResponse.java
Outdated
Show resolved
Hide resolved
스터디 수정 기능을 service와 controller에 추가
StudyCreateResponse에서 message를 제거하고 id만 반환하도록 함 MessageResponse DTO 제거
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/curriculum/domain/Curriculum.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
cmj7271
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DTO 는 record로 만드는걸로 통일하면 어떨까요
JsonFormat 은 compact constructor 에 작성하면 될거 같아요
cmj7271
reviewed
Jan 20, 2025
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/application/StudyService.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/dto/StudyCreateRequest.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/dto/StudyCreateResponse.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/application/StudyService.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/dto/StudyListResponse.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/dto/StudyDetailResponse.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/application/StudyService.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/api/StudyController.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/api/StudyController.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/application/StudyService.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/application/StudyService.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/dto/MessageResponse.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/api/StudyController.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/api/StudyController.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/api/StudyController.java
Outdated
Show resolved
Hide resolved
cmj7271
reviewed
Jan 20, 2025
src/main/java/com/gdgoc/study_group/study/application/StudyService.java
Outdated
Show resolved
Hide resolved
dto를 class에서 record로 변경함
- domain에 create 추가 - dto를 record로 변경
StudyDetailResponse와 StudyListResponse 통일
- 스터디장 권한이 필요한 함수는 LeaderStudyService로 분리 - dto 변경에 따른 수정
바뀐 response에 따라 수정함
호환성 문제로 springdoc 버전을 2.5.0에서 2.7.0으로 변경
cmj7271
reviewed
Jan 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 남겼습니다
src/main/java/com/gdgoc/study_group/curriculum/domain/Curriculum.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gdgoc/study_group/study/api/StudyController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gdgoc/study_group/study/application/LeaderStudyService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/gdgoc/study_group/study/application/StudentStudyService.java
Outdated
Show resolved
Hide resolved
- AllArgsConstructor 추가 - 불필요한 생성자 제거
service에서 curriculum과 day를 처리하는 로직을 domain으로 옮김
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
스터디 생성(수정필요)
스터디 전체 조회
스터디 정보 조회
스터디 삭제
스터디서비스 분리도 해야해요