test: 스터디 수료 쿠폰 관련 테스트 추가 #870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Caution Review failedThe pull request is closed. """ Walkthrough이번 PR은 CouponServiceTest 클래스에 새로운 nested 테스트 클래스와 메소드를 추가하여 스터디 수료 쿠폰의 발급과 회수 검증을 진행합니다. 두 개의 새로운 클래스(스터디_수료_쿠폰_발급시, 스터디_수료_쿠폰_회수시) 내에서 쿠폰 생성, 중복 확인, 신규 생성 및 회수 기능을 테스트하는 메소드가 추가되었으며, 관련 import 문도 함께 도입되었습니다. Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/test/java/com/gdschongik/gdsc/domain/coupon/application/CouponEventHandlerTest.java (1)
103-131: 수료 철회 이벤트에 대한 테스트도 잘 작성되었습니다!쿠폰 회수 로직이 정상적으로 동작하는지 확인하는 테스트가 잘 구현되어 있습니다. 다만, 다음과 같은 추가 테스트 케이스도 고려해 보시면 좋을 것 같습니다:
- 이미 회수된 쿠폰에 대한 중복 회수 시나리오
- 존재하지 않는 쿠폰에 대한 회수 시나리오
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
src/main/java/com/gdschongik/gdsc/domain/coupon/dao/IssuedCouponCustomRepositoryImpl.java(1 hunks)src/test/java/com/gdschongik/gdsc/domain/coupon/application/CouponEventHandlerTest.java(1 hunks)
🔇 Additional comments (3)
src/main/java/com/gdschongik/gdsc/domain/coupon/dao/IssuedCouponCustomRepositoryImpl.java (1)
46-46: fetchJoin 추가로 성능 최적화가 이루어졌습니다!
fetchJoin()을 추가하여 N+1 쿼리 문제를 해결하고 LazyInitializationException을 방지했습니다. 이는 쿼리 성능 향상에 도움이 될 것입니다.src/test/java/com/gdschongik/gdsc/domain/coupon/application/CouponEventHandlerTest.java (2)
29-101: 테스트 케이스가 잘 구성되어 있습니다!스터디 수료 이벤트 처리에 대한 테스트가 다음과 같이 잘 구성되어 있습니다:
- 기본 쿠폰 발급 시나리오
- 중복 발급 방지 시나리오
- 신규 쿠폰 생성 시나리오
각 테스트의 given/when/then 구조가 명확하고, 검증이 적절합니다.
1-132: 테스트 코드의 전반적인 구조가 훌륭합니다!다음과 같은 좋은 점들이 있습니다:
@Nested클래스를 사용하여 관련 테스트를 논리적으로 그룹화- 한글 메서드명을 사용하여 테스트 의도를 명확하게 전달
- given/when/then 주석을 통한 명확한 테스트 구조화
uwoobeat
requested changes
Feb 8, 2025
| @@ -43,6 +43,7 @@ public Optional<IssuedCoupon> findUnrevokedIssuedStudyCoupon(CouponType couponTy | |||
| return Optional.ofNullable(queryFactory | |||
| .selectFrom(issuedCoupon) | |||
| .leftJoin(issuedCoupon.coupon, coupon) | |||
| .fetchJoin() | |||
There was a problem hiding this comment.
조회 대상은 오직 IssuedCoupon이기 때문에, 페치 조인을 수행하고 싶다면 findFetchXXX 와 같은 컨벤션을 지켜야 합니다. 해당 메서드를 사용하는 로직을 보면 coupon 엔티티를 페치 조인해야 할 필요가 없습니다. 통합 테스트에서 어려움이 있다면 별도의 범용성 있는 페치 조인 로직을 추가하는 게 나아보입니다.
There was a problem hiding this comment.
test에서만 쓰는 메서드를 만들기 애매해서 기존 메서드를 수정했는데
test용 메서드 만드는 쪽으로 수정하겠습니다
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/com/gdschongik/gdsc/domain/coupon/dao/IssuedCouponQueryMethod.java (1)
56-64: matchesQueryOption 메서드 업데이트 제안새로 추가된
eqCouponType과eqStudy필터를matchesQueryOption메서드에도 포함시키는 것이 좋을 것 같습니다. 이를 위해서는IssuedCouponQueryOption클래스에도 관련 필드를 추가해야 합니다.다음과 같이 수정하는 것을 제안드립니다:
default BooleanBuilder matchesQueryOption(IssuedCouponQueryOption queryOption) { return new BooleanBuilder() .and(eqStudentId(queryOption.studentId())) .and(eqMemberName(queryOption.memberName())) .and(eqPhone(queryOption.phone())) .and(eqCouponName(queryOption.couponName())) .and(hasUsed(queryOption.hasUsed())) + .and(eqCouponType(queryOption.couponType())) + .and(eqStudy(queryOption.study())) .and(hasRevoked(queryOption.hasRevoked())); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
src/main/java/com/gdschongik/gdsc/domain/coupon/dao/IssuedCouponCustomRepository.java(2 hunks)src/main/java/com/gdschongik/gdsc/domain/coupon/dao/IssuedCouponCustomRepositoryImpl.java(1 hunks)src/main/java/com/gdschongik/gdsc/domain/coupon/dao/IssuedCouponQueryMethod.java(2 hunks)src/test/java/com/gdschongik/gdsc/domain/coupon/application/CouponEventHandlerTest.java(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (3)
- src/main/java/com/gdschongik/gdsc/domain/coupon/dao/IssuedCouponCustomRepositoryImpl.java
- src/main/java/com/gdschongik/gdsc/domain/coupon/dao/IssuedCouponCustomRepository.java
- src/test/java/com/gdschongik/gdsc/domain/coupon/application/CouponEventHandlerTest.java
🔇 Additional comments (2)
src/main/java/com/gdschongik/gdsc/domain/coupon/dao/IssuedCouponQueryMethod.java (2)
34-36: 구현이 잘 되었습니다!
eqCouponType메서드가 기존 메서드들과 일관된 패턴을 따르고 있으며, null 체크도 적절히 구현되어 있습니다.
38-40: 구현이 잘 되었습니다!
eqStudy메서드가 기존 메서드들과 일관된 패턴을 따르고 있으며, null 체크도 적절히 구현되어 있습니다.
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/main/java/com/gdschongik/gdsc/domain/coupon/dao/IssuedCouponCustomRepositoryImpl.java (1)
54-66: 메서드 설계에 대한 제안
findFetchIssuedCoupon메서드는fetchJoin컨벤션을 잘 따르고 있습니다.하지만 이전 리뷰 코멘트에서 논의된 것처럼, 테스트 전용 메서드를 별도로 만드는 것이 좋을 것 같습니다. 현재 구현은 범용적인 메서드처럼 보이지만, PR 목적에 따르면 테스트를 위한 것입니다.
findUnrevokedIssuedStudyCoupon와 상당 부분 중복되는 로직이 있습니다.다음과 같은 개선을 제안드립니다:
- public Optional<IssuedCoupon> findFetchIssuedCoupon( - CouponType couponType, Member member, @Nullable Study study, boolean hasRevoked) { + public Optional<IssuedCoupon> findFetchIssuedCouponForTest( + CouponType couponType, Member member, @Nullable Study study, boolean hasRevoked) { return Optional.ofNullable(queryFactory .selectFrom(issuedCoupon) .leftJoin(issuedCoupon.coupon, coupon) .fetchJoin() .where(eqMember(member) .and(eqStudy(study)) .and(hasRevoked(hasRevoked)) .and(eqCouponType(couponType))) .fetchFirst()); }또는 기존 메서드를 재사용하는 방식을 고려해보세요:
public Optional<IssuedCoupon> findUnrevokedIssuedStudyCoupon(CouponType couponType, Member member, Study study) { return Optional.ofNullable(queryFactory .selectFrom(issuedCoupon) .leftJoin(issuedCoupon.coupon, coupon) + .fetchJoin() .where(eqMember(member) .and(coupon.study.eq(study)) .and(hasRevoked(false)) .and(coupon.couponType.eq(couponType))) .fetchFirst()); } - public Optional<IssuedCoupon> findFetchIssuedCoupon( - CouponType couponType, Member member, @Nullable Study study, boolean hasRevoked) { - return Optional.ofNullable(queryFactory - .selectFrom(issuedCoupon) - .leftJoin(issuedCoupon.coupon, coupon) - .fetchJoin() - .where(eqMember(member) - .and(eqStudy(study)) - .and(hasRevoked(hasRevoked)) - .and(eqCouponType(couponType))) - .fetchFirst()); - }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/main/java/com/gdschongik/gdsc/domain/coupon/dao/IssuedCouponCustomRepositoryImpl.java(2 hunks)
🔇 Additional comments (1)
src/main/java/com/gdschongik/gdsc/domain/coupon/dao/IssuedCouponCustomRepositoryImpl.java (1)
13-13: LGTM!Nullable 파라미터를 위한 적절한 어노테이션 임포트입니다.
uwoobeat
requested changes
Feb 8, 2025
| import org.junit.jupiter.api.Test; | ||
| import org.springframework.beans.factory.annotation.Autowired; | ||
|
|
||
| public class CouponEventHandlerTest extends IntegrationTest { |
There was a problem hiding this comment.
음 핸들러의 역할과 책임은 그냥 서비스로 delegate 하는 것까지고,
테스트할 대상은 핸들러 내부에서 호출하는 서비스 로직이라고 봐야 하지 않을까요?
There was a problem hiding this comment.
MentorStudyHistoryServiceTest로 옮길게요
There was a problem hiding this comment.
test하는 로직이 CouponService에서 돌아가는 것들이니까 CouponServiceTest가 더 적절하겠네요
CouponServiceTest로 옮기고 리뷰 재요청하겠습니다.
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/test/java/com/gdschongik/gdsc/domain/coupon/application/CouponServiceTest.java (1)
206-275: 테스트 케이스의 가독성과 견고성을 개선할 수 있습니다.다음과 같은 개선사항을 제안드립니다:
- 각 테스트 메소드에
@DisplayName을 추가하여 테스트의 목적을 명확히 합니다.- 실패 케이스에 대한 테스트도 추가하면 좋을 것 같습니다.
- 쿠폰 금액이 정확한지 검증하는 assertion을 추가하면 좋을 것 같습니다.
예시 코드:
@Nested +@DisplayName("스터디 수료 쿠폰 발급 테스트") class 스터디_수료_쿠폰_발급시 { @Test + @DisplayName("스터디 수료시 쿠폰이 정상적으로 발급된다") void 발급쿠폰을_생성한다() { // ...existing code... assertThat(coupon.getCouponType()).isEqualTo(CouponType.STUDY_COMPLETION); assertThat(coupon.getStudy().getId()).isEqualTo(study.getId()); assertThat(issuedCoupon.getMember().getId()).isEqualTo(student.getId()); + assertThat(coupon.getDiscountAmount()).isEqualTo(Money.FIVE_THOUSAND); }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/test/java/com/gdschongik/gdsc/domain/coupon/application/CouponServiceTest.java(2 hunks)
🔇 Additional comments (1)
src/test/java/com/gdschongik/gdsc/domain/coupon/application/CouponServiceTest.java (1)
9-20: LGTM! 필요한 import 문들이 잘 추가되었습니다.도메인 객체와 값 객체들이 적절하게 import 되어 있습니다.
Comment on lines
277
to
303
| @Nested | ||
| class 스터디_수료_쿠폰_회수시 { | ||
|
|
||
| @Test | ||
| void 발급쿠폰을_회수한다() { | ||
| // given | ||
| Member student = createRegularMember(); | ||
| Member mentor = createMentor(); | ||
| LocalDateTime now = LocalDateTime.now(); | ||
| Study study = | ||
| createStudy(mentor, Period.of(now.plusDays(5), now.plusDays(10)), Period.of(now.minusDays(5), now)); | ||
|
|
||
| StudyHistory studyHistory = createStudyHistory(student, study); | ||
|
|
||
| couponService.createAndIssueCouponByStudyHistories(List.of(student.getId())); | ||
| IssuedCoupon issuedCoupon = issuedCouponRepository | ||
| .findFetchIssuedCoupon(CouponType.STUDY_COMPLETION, student, study, false) | ||
| .orElseThrow(); | ||
|
|
||
| // when | ||
| couponService.revokeStudyCompletionCouponByStudyHistoryId(student.getId()); | ||
|
|
||
| // then | ||
| issuedCoupon = issuedCouponRepository.findById(issuedCoupon.getId()).orElseThrow(); | ||
| assertThat(issuedCoupon.getHasRevoked()).isTrue(); | ||
| } | ||
| } |
There was a problem hiding this comment.
🛠️ Refactor suggestion
회수 관련 테스트 케이스를 보강해야 합니다.
다음과 같은 실패 케이스에 대한 테스트를 추가하면 좋을 것 같습니다:
- 존재하지 않는 스터디 히스토리 ID로 회수 시도
- 이미 사용된 쿠폰 회수 시도
- 이미 회수된 쿠폰 재회수 시도
예시 코드:
@Nested
+@DisplayName("스터디 수료 쿠폰 회수 테스트")
class 스터디_수료_쿠폰_회수시 {
+ @Test
+ @DisplayName("존재하지 않는 스터디 히스토리로 회수 시도시 예외가 발생한다")
+ void 존재하지_않는_스터디_히스토리로_회수시_실패한다() {
+ // given
+ Long nonExistentStudyHistoryId = 999L;
+
+ // when & then
+ assertThatThrownBy(
+ () -> couponService.revokeStudyCompletionCouponByStudyHistoryId(nonExistentStudyHistoryId))
+ .isInstanceOf(CustomException.class)
+ .hasMessageContaining(STUDY_HISTORY_NOT_FOUND.getMessage());
+ }📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| @Nested | |
| class 스터디_수료_쿠폰_회수시 { | |
| @Test | |
| void 발급쿠폰을_회수한다() { | |
| // given | |
| Member student = createRegularMember(); | |
| Member mentor = createMentor(); | |
| LocalDateTime now = LocalDateTime.now(); | |
| Study study = | |
| createStudy(mentor, Period.of(now.plusDays(5), now.plusDays(10)), Period.of(now.minusDays(5), now)); | |
| StudyHistory studyHistory = createStudyHistory(student, study); | |
| couponService.createAndIssueCouponByStudyHistories(List.of(student.getId())); | |
| IssuedCoupon issuedCoupon = issuedCouponRepository | |
| .findFetchIssuedCoupon(CouponType.STUDY_COMPLETION, student, study, false) | |
| .orElseThrow(); | |
| // when | |
| couponService.revokeStudyCompletionCouponByStudyHistoryId(student.getId()); | |
| // then | |
| issuedCoupon = issuedCouponRepository.findById(issuedCoupon.getId()).orElseThrow(); | |
| assertThat(issuedCoupon.getHasRevoked()).isTrue(); | |
| } | |
| } | |
| @Nested | |
| @DisplayName("스터디 수료 쿠폰 회수 테스트") | |
| class 스터디_수료_쿠폰_회수시 { | |
| @Test | |
| @DisplayName("존재하지 않는 스터디 히스토리로 회수 시도시 예외가 발생한다") | |
| void 존재하지_않는_스터디_히스토리로_회수시_실패한다() { | |
| // given | |
| Long nonExistentStudyHistoryId = 999L; | |
| // when & then | |
| assertThatThrownBy( | |
| () -> couponService.revokeStudyCompletionCouponByStudyHistoryId(nonExistentStudyHistoryId)) | |
| .isInstanceOf(CustomException.class) | |
| .hasMessageContaining(STUDY_HISTORY_NOT_FOUND.getMessage()); | |
| } | |
| @Test | |
| void 발급쿠폰을_회수한다() { | |
| // given | |
| Member student = createRegularMember(); | |
| Member mentor = createMentor(); | |
| LocalDateTime now = LocalDateTime.now(); | |
| Study study = | |
| createStudy(mentor, Period.of(now.plusDays(5), now.plusDays(10)), Period.of(now.minusDays(5), now)); | |
| StudyHistory studyHistory = createStudyHistory(student, study); | |
| couponService.createAndIssueCouponByStudyHistories(List.of(student.getId())); | |
| IssuedCoupon issuedCoupon = issuedCouponRepository | |
| .findFetchIssuedCoupon(CouponType.STUDY_COMPLETION, student, study, false) | |
| .orElseThrow(); | |
| // when | |
| couponService.revokeStudyCompletionCouponByStudyHistoryId(student.getId()); | |
| // then | |
| issuedCoupon = issuedCouponRepository.findById(issuedCoupon.getId()).orElseThrow(); | |
| assertThat(issuedCoupon.getHasRevoked()).isTrue(); | |
| } | |
| } |
uwoobeat
requested changes
Feb 9, 2025
| StudyHistory studyHistory = createStudyHistory(student, study); | ||
|
|
||
| // when | ||
| couponService.createAndIssueCouponByStudyHistories(List.of(student.getId())); |
There was a problem hiding this comment.
Suggested change
| couponService.createAndIssueCouponByStudyHistories(List.of(student.getId())); | |
| couponService.createAndIssueCouponByStudyHistories(List.of(1L)); |
|
|
||
| couponService.createAndIssueCouponByStudyHistories(List.of(student.getId())); | ||
|
|
||
| // then |
There was a problem hiding this comment.
전체 스터디 수료 쿠폰 조회해와서 사이즈만 검증하면 될듯요
| StudyHistory studyHistory = createStudyHistory(student, study); | ||
|
|
||
| couponService.createAndIssueCouponByStudyHistories(List.of(student.getId())); | ||
| IssuedCoupon issuedCoupon = issuedCouponRepository |
There was a problem hiding this comment.
여기도 위에 있는 리뷰랑 마찬가지로 1L 쓰면 되겠네요
수정했습니다
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
There was a problem hiding this comment.
Actionable comments posted: 0
♻️ Duplicate comments (1)
src/test/java/com/gdschongik/gdsc/domain/coupon/application/CouponServiceTest.java (1)
273-296: 🛠️ Refactor suggestion회수 관련 테스트 케이스를 보강해 주세요.
이전 리뷰에서 제안된 대로, 다음과 같은 실패 케이스에 대한 테스트를 추가하면 좋을 것 같습니다:
- 존재하지 않는 스터디 히스토리 ID로 회수 시도
- 이미 사용된 쿠폰 회수 시도
- 이미 회수된 쿠폰 재회수 시도
+ @Test + void 존재하지_않는_스터디_히스토리로_회수시_실패한다() { + // given + Long nonExistentStudyHistoryId = 999L; + + // when & then + assertThatThrownBy( + () -> couponService.revokeStudyCompletionCouponByStudyHistoryId(nonExistentStudyHistoryId)) + .isInstanceOf(CustomException.class) + .hasMessageContaining(STUDY_HISTORY_NOT_FOUND.getMessage()); + } + + @Test + void 이미_사용된_쿠폰_회수시_실패한다() { + // given + setUp(); + couponService.createAndIssueCouponByStudyHistories(List.of(1L)); + IssuedCoupon issuedCoupon = issuedCouponRepository.findById(1L).orElseThrow(); + issuedCoupon.use(LocalDateTime.now()); + + // when & then + assertThatThrownBy( + () -> couponService.revokeStudyCompletionCouponByStudyHistoryId(student.getId())) + .isInstanceOf(CustomException.class) + .hasMessageContaining(COUPON_NOT_REVOKABLE_ALREADY_USED.getMessage()); + } + + @Test + void 이미_회수된_쿠폰_재회수시_실패한다() { + // given + setUp(); + couponService.createAndIssueCouponByStudyHistories(List.of(1L)); + couponService.revokeStudyCompletionCouponByStudyHistoryId(student.getId()); + + // when & then + assertThatThrownBy( + () -> couponService.revokeStudyCompletionCouponByStudyHistoryId(student.getId())) + .isInstanceOf(CustomException.class) + .hasMessageContaining(COUPON_NOT_REVOKABLE_ALREADY_REVOKED.getMessage()); + }
🧹 Nitpick comments (2)
src/test/java/com/gdschongik/gdsc/domain/coupon/application/CouponServiceTest.java (2)
211-229: 테스트 검증을 보강해 주세요.발급된 쿠폰의 개수뿐만 아니라 다음 속성들도 검증하면 좋을 것 같습니다:
- 발급된 쿠폰의 할인 금액이 정확한지
- 발급된 쿠폰의 타입이
STUDY_COMPLETION인지- 발급된 쿠폰이 올바른 학생에게 할당되었는지
// then Page<IssuedCoupon> issuedCoupons = issuedCouponRepository.findAllIssuedCoupons( new IssuedCouponQueryOption(null, null, null, null, null, null), PageRequest.of(0, 10)); assertThat(issuedCoupons.getTotalElements()).isEqualTo(1L); +IssuedCoupon issuedCoupon = issuedCoupons.getContent().get(0); +assertThat(issuedCoupon.getCoupon().getDiscountAmount()).isEqualTo(Money.FIVE_THOUSAND); +assertThat(issuedCoupon.getCoupon().getType()).isEqualTo(CouponType.STUDY_COMPLETION); +assertThat(issuedCoupon.getMember().getId()).isEqualTo(student.getId());
211-270: 테스트 코드 중복을 제거해 주세요.세 개의 테스트 메소드에서 동일한 테스트 데이터 설정 코드가 반복됩니다.
@BeforeEach를 사용하여 공통 설정을 추출하면 좋을 것 같습니다.+ private Member student; + private Study study; + private StudyHistory studyHistory; + + @BeforeEach + void setUp() { + Member mentor = createMentor(); + student = createRegularMember(); + LocalDateTime now = LocalDateTime.now(); + study = createStudy(mentor, + Period.of(now.plusDays(5), now.plusDays(10)), + Period.of(now.minusDays(5), now)); + studyHistory = createStudyHistory(student, study); + }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/test/java/com/gdschongik/gdsc/domain/coupon/application/CouponServiceTest.java(2 hunks)
uwoobeat
approved these changes
Feb 9, 2025
|
|
||
| // then | ||
| List<Coupon> coupons = couponRepository.findAll(); | ||
| assertThat(coupons.size()).isEqualTo(1L); |
There was a problem hiding this comment.
Suggested change
| assertThat(coupons.size()).isEqualTo(1L); | |
| assertThat(coupons).hasSize(1); |
Job Summary for GradleCheck Style and Test to Develop :: build-test
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌱 관련 이슈
📌 작업 내용 및 특이사항
lazyinitializationexception이 발생해서 fetchJoin 추가했습니다.📝 참고사항
📚 기타
Summary by CodeRabbit