Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: eslint - github actions 설정 #13

Merged
merged 5 commits into from
Jul 31, 2024
Merged

Fix: eslint - github actions 설정 #13

merged 5 commits into from
Jul 31, 2024

Conversation

soulchicken
Copy link
Member

@soulchicken soulchicken commented Jul 31, 2024 •
edited
Loading

Fix: eslint - github actions 설정

PR을 한 이유 🎯

  • 깃헙 액션으로 모든 TS, JS 코드를 ESLint 체크를 합니다.

이슈 번호 📎

변경사항 🛠

  • 깃헙 액션으로 모든 TS, JS 코드를 ESLint 체크를 합니다.
  • import 해놓고 안쓴 코드를 TS에서 Error로 처리하게 되있기 때문에 ESLint로도 가능하게 해야겠어요.

특이사항 📌

  • �프리 커밋 단계에서는 lint-staged된 코드만 린트체크하지만 PR시에는 모든 코드를 체크하도록 했어요.

@soulchicken
Copy link
Member Author

Lint 체크가 정말 잘 되고 있군요.

image

@soulchicken
chore: import eslint plugin
e161e99
@soulchicken
chore: 패키지 삽질
4786f43 
미안합니다. import react만 막는 방법을 못찾겠어용
@soulchicken
fix: any타입과 lint 체크대로 변경
6bb5671 
- @leejuhi 이제부터는 lint가 잘 먹길바랄게요.
@soulchicken soulchicken merged commit 72a7e70 into develop Jul 31, 2024
1 check passed
@soulchicken soulchicken deleted the fix/lint-actions branch August 2, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@soulchicken