[Yunjanghyeon] 프론트엔드 2주차 미션 제출합니다. #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhkdev
reviewed
Dec 9, 2024
Comment on lines
+1
to
+9
| async function asynchronous(){ | ||
| let response = await fetch('https://jsonplaceholder.typicode.com/posts/') | ||
| let jsonarray = await response.json() | ||
| jsonarray.forEach(element => { | ||
| console.log(element.title) | ||
| }); | ||
| } | ||
|
|
||
| asynchronous() |
There was a problem hiding this comment.
딱 제가 원하는 정답이네요. 이걸로 어떻게 호출할 수 있는지에 대해 이해하셧으면 합니다
Comment on lines
+9
to
+10
| <div className='App'> | ||
| <BrowserRouter> |
There was a problem hiding this comment.
혹시 BrowserRouter로 감싸고 그 위에 div로 또 감싼 이유가 있을까여? 굳이 감싸지 않아도 될거 같군여
추가로 BrowserRouter를 여기서 감싸는거도 좋지만 index.js에서 App태그를 감쌈으로 적용할수도 잇습니당
| @@ -0,0 +1,25 @@ | |||
| import React from 'react'; | |||
| import { Link } from 'react-router-dom'; | |||
| import styles from "./Main.module.css" | |||
There was a problem hiding this comment.
module.css를 적용해본게 인상깊네여 추가적으로 emotion/styled component에 대해서 공부해봐도 좋을거 가탕여
Comment on lines
+7
to
+9
| border-style: solid; | ||
| border-radius: 40px 0px 0px 40px; | ||
| border-color: white; |
There was a problem hiding this comment.
border라는 속성을 아는데 일부러 쪼갠건가여? 아니라면 border 속성으로 한번에 작성하는 쪽으로 합시당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.