["clo-or”] "front-end” 2주차 미션 제출합니다. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hhhkdev
reviewed
Dec 8, 2024
| } | ||
| const data = await response.json(); | ||
|
|
||
| data.forEach(post => { |
There was a problem hiding this comment.
forEach를 사용하여 처리한거 굉장히 마음에 드네요. 단순히 for문을 사용하는거보다 더 코드가 직관적이고 효율적이네요.
Comment on lines
+1
to
+7
| async function fetchAndPrintTitles() { | ||
| try { | ||
| const response = await fetch('https://jsonplaceholder.typicode.com/posts/'); | ||
| if (!response.ok) { | ||
| throw new Error(`HTTP error! status: ${response.status}`); | ||
| } | ||
| const data = await response.json(); |
There was a problem hiding this comment.
코드가 굉장히 깔끔하고 에러처리까지 챙겨야 할 내용을 모두 챙겼네용 멋집니다
Comment on lines
+1
to
+14
|
|
||
| button { | ||
| background-color: #007bff; | ||
| padding: 10px 20px; | ||
| margin: 10px; | ||
| color: white; | ||
| border: none; | ||
| border-radius: 5px; | ||
| font-size: 20px; | ||
| } | ||
| *{ | ||
| padding: 5px; | ||
| margin: 5px; | ||
| } |
There was a problem hiding this comment.
전반적으로 띄어쓰기 간격이 일정하지 않은거 같아요. VS Code에서 Prettier와 관련한 설정을 찾아보고 적용한다면 저장만 해도 코드 포맷이 적용되는 모습을 볼 수 있습니당
|
|
||
| const App = () => { | ||
| return ( | ||
| <Router> |
There was a problem hiding this comment.
BrowserRouter가 없길래 찾아보니 as를 이용해서 Router로 가져왔었네여 해당 로 감싸는 걸 App.js가 아니라, index.js에서 App태그를 감싸서 이용할 수도 있습니다!
Comment on lines
+9
to
+10
| <button onClick={() => navigate('/velog')}>velog</button> | ||
| <button onClick={() => navigate('/picture')}>picture</button> |
There was a problem hiding this comment.
명세에 적어놓은 내용은 태그를 이용하여 이동하는 걸 생각했었는데 다른 방식이네여 하지만 useNavigate 사용 방식을 알아낸 듯하니 다행입니당
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.