[mirupio] 1주차 미션 제출합니다 #18
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2주차 미션 코드에 대한 전반적인 코드 리뷰를 하자면 서비스 계층과 DTO 구현없이 진행하셔서 게임 로직이 각 도메인과 컨트롤러 계층에 구현이 되어있어서 추후에 코드의 유지보수성과 확장성이 떨어질 수 있을 것 같아요. 추후에 서비스계층과 DTO에 대해서 학습해보시고 로직은 서비스계층으로 분리, 응답값은 DTO로 구현해보시는 시도를 해보시면 좋을 것 같아요 ! 로직은 세세하게 잘 짜주신 것 같아요 고생하셨어용🥹 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(git 사용이 미숙해서 commit이 엉망진창이 돼버렸네요...코드는 레포지토리 들어가서 확인 부탁드립니다 ㅠㅠㅠ....)