[pull] master from trinodb:master #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![g-research-pull[bot]](https://avatars.githubusercontent.com/u/21341965?s=60&v=4){kind=small}
This solves an issue with connection leaks that are happening for Azure Storage SDK when OkHttp is used. OkHttp is not actively maintained, which makes the default, Netty implementation, a better choice for the future as it's actively maintained and tested.
Event loop group/maximum number of concurrent requests are already configured so the removed setting was a noop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
g-research-pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )