Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAD-1: HR Module- CPDA and LTC forms implemented #1318

Closed
wants to merge 1 commit into from

Conversation

Akshay-Pahuja
Copy link

@Akshay-Pahuja Akshay-Pahuja commented Mar 8, 2024

Issue that this pull request solves

Closes: # (issue number)

Proposed changes

  • no issues present
  • made from scratch

Brief description of what is fixed or changed

New Features implemented

  • LTC form implemented : submission, view, hr can see requests, hod see requests, file getting forwarded, director view requests,
  • CPDA form implemented : submission , view, hr can see requests, hod see requests, file getting forwarded, director view requests,

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

@FusionIIIT-Bot
Copy link
Collaborator

Congratulations for making your first Pull Request at Fusion!! 🎉 Someone from our team will review it soon.

@Akshay-Pahuja Akshay-Pahuja changed the title HR Module: CPDA and LTC forms implemented GAD-1: HR Module- CPDA and LTC forms implemented Mar 8, 2024
@Akshay-Pahuja
Copy link
Author

Maintainers to be tagged :
@prajjwalkapoor

Copy link

@prajjwalkapoor prajjwalkapoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Akshay-Pahuja, LGTM. Just do this minor change commit it on the same branch.

@@ -0,0 +1,97 @@
<!-- {% extends 'globals/base.html' %}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't need these files then instead of commenting, let's remove them.

@@ -0,0 +1,33 @@
<!-- <div class="content">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, we can remove this.

@prajjwalkapoor
Copy link

Also @Akshay-Pahuja, we need a walkthrough video of your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants