Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAD - 4 : Create File Tracking SDK and make the Web Application completely functional #1295

Merged
merged 59 commits into from
Mar 11, 2024

Conversation

theoden42
Copy link

@theoden42 theoden42 commented Feb 19, 2024

Issue that this pull request solves

  1. Web Views for inbox, outbox, archiving, drafts, forwarding, and history of the file were not working properly
  2. Templates were incorrect and did not show data in correct order
  3. View file template and view were not present
  4. File and Tracking Model lacked field for generalisation (API for other modules)
  5. Seriallizers were not present for the data

Closes: # (issue number)

Proposed changes

  1. Updated the models for generalisation
  2. Create Comprehensive filetracking SDK
  3. Use Filetracking SDK methods to implement required views and fix incorrect ones
  4. Update Templates for inbox, outbox, drafts, archive and others
  5. Add templates which are missing eg: view_file, finish_file

Brief description of what is fixed or changed

The filetracking sdk now includes methods for implementation of workflow in other modules. The filetracking web view is now functional for employees and they can view, send, track, forward, archive, draft the files with attachments.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

Please attach the screenshots of the changes made in case of change in user interface

Other information

Any other information that is important to this pull request

@FusionIIIT-Bot
Copy link
Collaborator

Congratulations for making your first Pull Request at Fusion!! 🎉 Someone from our team will review it soon.

@theoden42
Copy link
Author

@prajjwalkapoor please review

@prajjwalkapoor
Copy link

@theoden42 LGTM.
Just make a small walkthrough video.

@theoden42
Copy link
Author

Sure. Here is the walkthrough of the web interface @prajjwalkapoor.
video

@prajjwalkapoor prajjwalkapoor merged commit 4962f02 into FusionIIIT:gad-4 Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants