Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ac-6 : week-5: create api #1294

Merged
merged 2 commits into from
Feb 22, 2024
Merged

ac-6 : week-5: create api #1294

merged 2 commits into from
Feb 22, 2024

Conversation

aryan0723
Copy link

Issue that this pull request solves

created api through django-rest-framework for department module

Brief description of what is fixed or changed

api created for announcements in department module

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have performed a self-review of my own code
  • [ x ] I have created new branch for this pull request
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ x ] My changes generate no new warnings
  • [ x ] My changes does not break the current system and it passes all the current test cases.

@FusionIIIT-Bot
Copy link
Collaborator

Congratulations for making your first Pull Request at Fusion!! 🎉 Someone from our team will review it soon.

@prajjwalkapoor
Copy link

@aryan0723 The change looks good, but currently, we are fetching all the announcements regardless of the users. Maybe we could add some filtrations so users get announcements relevant to them.

@aryan0723
Copy link
Author

@prajjwalkapoor yes, also I am thinking of adding more API's for better availability of data

@prajjwalkapoor prajjwalkapoor merged commit 6534802 into FusionIIIT:ac-6 Feb 22, 2024
rush1kesh-010 pushed a commit to rush1kesh-010/Fusion that referenced this pull request Feb 23, 2024
* feat: create api

* feat:create more routes
prajjwalkapoor added a commit that referenced this pull request Feb 23, 2024
* feat: enable dashboard department button, optimize code

* ac-6 : week-5: create api (#1294)

* feat: create api

* feat:create more routes

* feat : enable notification, fix docker issues

---------

Co-authored-by: Aryan Shrivastava <[email protected]>
Co-authored-by: Prajjwal kapoor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants