Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove analysis code #2704

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Remove analysis code #2704

merged 2 commits into from
Feb 12, 2025

Conversation

MitchTurner
Copy link
Member

@MitchTurner MitchTurner commented Feb 11, 2025

Linked Issues/PRs

Removed in favor of the simulation in the fuel-core-utils:
https://github.com/FuelLabs/fuel-core-utils/pull/11

Description

This is the old simulation code that is obsolete now.

Before requesting review

  • I have reviewed the code myself

@MitchTurner MitchTurner added the no changelog Skip the CI check of the changelog modification label Feb 11, 2025
@MitchTurner MitchTurner marked this pull request as ready for review February 11, 2025 21:42
@MitchTurner
Copy link
Member Author

Should I include a changelog entry for this, even if it's not published or part of the workspace? Seems borderline since someone might be using it.

Copy link
Collaborator

@xgreenx xgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just approved without analyzing=D

@MitchTurner MitchTurner merged commit c206507 into master Feb 12, 2025
33 checks passed
@MitchTurner MitchTurner deleted the chore/remove-gas-price-analysis branch February 12, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants