-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added blacklisting transaction on the TxPool
#1743
Added blacklisting transaction on the TxPool
#1743
Conversation
TxPool
TxPool
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sounds like every node will need to have the same blacklist in their startup args. Otherwise, some nodes will accept the TX, while some will not.
pub tx_pool_ttl: humantime::Duration, | ||
|
||
/// The max number of transactions that the `TxPool` can simultaneously store. | ||
#[clap(long = "tx-max-number", default_value = "4064", env)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did the "4064" come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it was just copied over from before
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! pushed a version bump commit as well so we can release this.
Co-authored-by: Brandon Kite <[email protected]>
Duplicates the #1743 for the `master` --------- Co-authored-by: Brandon Kite <[email protected]>
Duplicates the FuelLabs/fuel-core#1743 for the `master` --------- Co-authored-by: Brandon Kite <[email protected]>
No description provided.