Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added blacklisting transaction on the TxPool #1743

Merged

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Mar 8, 2024

No description provided.

@xgreenx xgreenx requested a review from a team March 8, 2024 19:23
@xgreenx xgreenx self-assigned this Mar 8, 2024
@xgreenx xgreenx changed the title Added blacklisting transaction on hte TxPool Added blacklisting transaction on the TxPool Mar 8, 2024
Copy link
Contributor

@bvrooman bvrooman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like every node will need to have the same blacklist in their startup args. Otherwise, some nodes will accept the TX, while some will not.

pub tx_pool_ttl: humantime::Duration,

/// The max number of transactions that the `TxPool` can simultaneously store.
#[clap(long = "tx-max-number", default_value = "4064", env)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did the "4064" come from?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it was just copied over from before

Copy link
Member

@Voxelot Voxelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! pushed a version bump commit as well so we can release this.

@xgreenx xgreenx merged commit a31f64b into release/v0.22.4 Mar 9, 2024
31 checks passed
@xgreenx xgreenx deleted the feature/support-blacklisting-on-txpool-level branch March 9, 2024 00:24
xgreenx added a commit that referenced this pull request Mar 11, 2024
xgreenx added a commit that referenced this pull request Mar 11, 2024
Duplicates the #1743 for the
`master`

---------

Co-authored-by: Brandon Kite <[email protected]>
crypto523 pushed a commit to crypto523/fuel-core that referenced this pull request Oct 7, 2024
Duplicates the FuelLabs/fuel-core#1743 for the
`master`

---------

Co-authored-by: Brandon Kite <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants