Motor resonance filter #131
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request introduces a motor resonance filter feature to Shake&Tune, allowing users to apply and remove motor resonance filters. It also includes refactoring for better configuration initialization and command registration, and updates the documentation to reflect the new configuration options. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @Frix-x - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 9 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
|
@sourcery-ai review |
There was a problem hiding this comment.
Hey @Frix-x - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 8 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 3 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Zeanon
reviewed
Aug 25, 2024
| # In DangerKlipper, the pulse train is large enough to allow the | ||
| # convolution of any shapers in order to craft the new combined shapers | ||
| # so we can use the MZV shaper (that looks to be the best for this purpose) | ||
| df = math.sqrt(1.0 - self.damping_x**2) |
There was a problem hiding this comment.
You only use damping_x here for both x and y (while technically they should be the same it doesnt make sense to have them seperate and then just ignore the value for y)
Same thing for the freuqncy
Frix-x
added
the
experimental
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
Summary by Sourcery
This pull request introduces a motor resonance filter feature to Shake&Tune, allowing users to apply and remove motor resonance filters for X and Y axes. It also includes refactoring of the ShakeTune class for better configuration and command handling, enhancements to motor frequency profile computation, and updates to the documentation to reflect the new configuration options.